You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/11/06 02:41:55 UTC
[PR] [feat] add social card for render [pulsar-site]
tisonkun opened a new pull request, #723:
URL: https://github.com/apache/pulsar-site/pull/723
This PR fixes https://github.com/apache/pulsar/issues/21478
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `./preview.sh` at root path) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [feat] add social card for render [pulsar-site]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on PR #723:
URL: https://github.com/apache/pulsar-site/pull/723#issuecomment-1794491960
@tisonkun See https://github.com/apache/pulsar-site/pull/725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [feat] add social card for render [pulsar-site]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #723:
URL: https://github.com/apache/pulsar-site/pull/723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [feat] add social card for render [pulsar-site]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on PR #723:
URL: https://github.com/apache/pulsar-site/pull/723#issuecomment-1794027579
The image background probably should filled with some color.
Otherwise, white text will be invisible on a white background.
Examples:
- https://assets-global.website-files.com/638a1dc72083d166ed6e3d76/63ad9cce111f58c7b64b646f_og-streamnative.webp
- https://cdn.confluent.io/wp-content/uploads/seo-logo-meadow.png
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [feat] add social card for render [pulsar-site]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #723:
URL: https://github.com/apache/pulsar-site/pull/723#issuecomment-1794059744
Yep. I try to use a different image - https://github.com/apache/pulsar-site/commit/ed1ebc18d089b083d7edb6f8dcfdf1053675b9fb
Now there is an image. But it may not be optimal for display.. Perhaps we need a resize?
<img width="1130" alt="image" src="https://github.com/apache/pulsar-site/assets/18818196/52479820-9052-48a9-a93f-5a3d5b0f5a50">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [feat] add social card for render [pulsar-site]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on PR #723:
URL: https://github.com/apache/pulsar-site/pull/723#issuecomment-1794027663
https://socialsharepreview.com/?url=https://pulsar.apache.org
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org