You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Paul Isaychuk <pi...@hortonworks.com> on 2015/05/27 20:01:51 UTC
Review Request 34722: [FALCON-1241] Fix SearchApiTest according to
changes in API, tag ClusterSetupTest,
PrismProcessScheduleTest#testScheduleDeletedProcessOnBothColos
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34722/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1241
https://issues.apache.org/jira/browse/FALCON-1241
Repository: falcon-git
Description
-------
1) API changed: entity/list/schedulable -> entity/list/feed,process. Replacing 'schedulable' param with 'feed,process'
2) search-ui tag was missed in ClusterSetupTest
3) testScheduleDeletedProcessOnBothColos is distributed (uses 2 falcon servers), was tagged as embedded by mistake
Diffs
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SearchApiTest.java b317944
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java c5bfdf1
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java 95854ca
Diff: https://reviews.apache.org/r/34722/diff/
Testing
-------
Thanks,
Paul Isaychuk
Re: Review Request 34722: [FALCON-1241] Fix SearchApiTest according to
changes in API, tag ClusterSetupTest,
PrismProcessScheduleTest#testScheduleDeletedProcessOnBothColos
Posted by Raghav Gautam <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34722/#review85442
-----------------------------------------------------------
Ship it!
Ship It!
- Raghav Gautam
On May 27, 2015, 11:01 a.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34722/
> -----------------------------------------------------------
>
> (Updated May 27, 2015, 11:01 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1241
> https://issues.apache.org/jira/browse/FALCON-1241
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> 1) API changed: entity/list/schedulable -> entity/list/feed,process. Replacing 'schedulable' param with 'feed,process'
> 2) search-ui tag was missed in ClusterSetupTest
> 3) testScheduleDeletedProcessOnBothColos is distributed (uses 2 falcon servers), was tagged as embedded by mistake
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SearchApiTest.java b317944
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java c5bfdf1
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java 95854ca
>
> Diff: https://reviews.apache.org/r/34722/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 34722: [FALCON-1241] Fix SearchApiTest according to
changes in API, tag ClusterSetupTest,
PrismProcessScheduleTest#testScheduleDeletedProcessOnBothColos
Posted by Paul Isaychuk <pi...@hortonworks.com>.
> On May 27, 2015, 6:22 p.m., Raghav Gautam wrote:
> > Were you able to test your changes ?
1) was not able to test (have old cluster)
2) 3) does't need to be tested (only tag added)
- Paul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34722/#review85404
-----------------------------------------------------------
On May 27, 2015, 6:01 p.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34722/
> -----------------------------------------------------------
>
> (Updated May 27, 2015, 6:01 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1241
> https://issues.apache.org/jira/browse/FALCON-1241
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> 1) API changed: entity/list/schedulable -> entity/list/feed,process. Replacing 'schedulable' param with 'feed,process'
> 2) search-ui tag was missed in ClusterSetupTest
> 3) testScheduleDeletedProcessOnBothColos is distributed (uses 2 falcon servers), was tagged as embedded by mistake
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SearchApiTest.java b317944
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java c5bfdf1
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java 95854ca
>
> Diff: https://reviews.apache.org/r/34722/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 34722: [FALCON-1241] Fix SearchApiTest according to
changes in API, tag ClusterSetupTest,
PrismProcessScheduleTest#testScheduleDeletedProcessOnBothColos
Posted by Raghav Gautam <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34722/#review85404
-----------------------------------------------------------
Were you able to test your changes ?
- Raghav Gautam
On May 27, 2015, 11:01 a.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34722/
> -----------------------------------------------------------
>
> (Updated May 27, 2015, 11:01 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1241
> https://issues.apache.org/jira/browse/FALCON-1241
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> 1) API changed: entity/list/schedulable -> entity/list/feed,process. Replacing 'schedulable' param with 'feed,process'
> 2) search-ui tag was missed in ClusterSetupTest
> 3) testScheduleDeletedProcessOnBothColos is distributed (uses 2 falcon servers), was tagged as embedded by mistake
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SearchApiTest.java b317944
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java c5bfdf1
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java 95854ca
>
> Diff: https://reviews.apache.org/r/34722/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Paul Isaychuk
>
>