You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/08/09 10:19:20 UTC
[GitHub] [incubator-yunikorn-web] kobe860219 opened a new pull request #62: [YUNIKORN-775] Create github action to build web UI
kobe860219 opened a new pull request #62:
URL: https://github.com/apache/incubator-yunikorn-web/pull/62
### What is this PR for?
Add a github action workflow file to replace travis with github action. Unit test, build test and coverage test are included in this workflow.
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-775
### How should this be tested?
### Screenshots (if appropriate)
<img width="1440" alt="ζͺε 2021-08-09 δΈε6 11 46" src="https://user-images.githubusercontent.com/48027290/128691994-19cb38e8-f7da-483a-bdd4-7488af141dac.png">
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] yangwwei merged pull request #62: [YUNIKORN-775] Create github action to build web UI
Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #62:
URL: https://github.com/apache/incubator-yunikorn-web/pull/62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] kobe860219 commented on pull request #62: [YUNIKORN-775] Create github action to build web UI
Posted by GitBox <gi...@apache.org>.
kobe860219 commented on pull request #62:
URL: https://github.com/apache/incubator-yunikorn-web/pull/62#issuecomment-895111823
@yangwwei This workflow not run e2e test. Maybe we could skip it because it passed in the travis test and we won't use e2e for testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] yangwwei commented on a change in pull request #62: [YUNIKORN-775] Create github action to build web UI
Posted by GitBox <gi...@apache.org>.
yangwwei commented on a change in pull request #62:
URL: https://github.com/apache/incubator-yunikorn-web/pull/62#discussion_r685699956
##########
File path: .github/workflows/main.yaml
##########
@@ -0,0 +1,37 @@
+name: Pre-commit Checks
+
+on:
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Checkout Source Code
+ uses: actions/checkout@v2
+ with:
+ fetch-depth: 2
+
+ - name: Check License
+ run: make license-check
+
+ - name: Set Node.js Environment
+ uses: actions/setup-node@v2
+ with:
+ node-version: 12.14
+ - run: npm install -g @angular/cli > /dev/null
+ - run: npm install karma
+ - run: npm install -g protractor
+ - run: yarn install
Review comment:
I think this can be simplified to:
```
run: |
npm install -g @angular/cli > /dev/null
npm install karma
...
```
the above syntax is supported in github action for multi-line commands.
##########
File path: .github/workflows/main.yaml
##########
@@ -0,0 +1,37 @@
+name: Pre-commit Checks
+
+on:
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Checkout Source Code
+ uses: actions/checkout@v2
+ with:
+ fetch-depth: 2
+
+ - name: Check License
+ run: make license-check
+
+ - name: Set Node.js Environment
+ uses: actions/setup-node@v2
+ with:
+ node-version: 12.14
+ - run: npm install -g @angular/cli > /dev/null
+ - run: npm install karma
+ - run: npm install -g protractor
+ - run: yarn install
+
+ - name: Unit Test
+ run: ng test --watch=false
+
+ - name: Build Test
+ run: ng build
Review comment:
This should be "Build", not the "Build test"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] kobe860219 commented on pull request #62: [YUNIKORN-775] Create github action to build web UI
Posted by GitBox <gi...@apache.org>.
kobe860219 commented on pull request #62:
URL: https://github.com/apache/incubator-yunikorn-web/pull/62#issuecomment-895775127
And I modified the "syntax" and "name of build" .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] kobe860219 edited a comment on pull request #62: [YUNIKORN-775] Create github action to build web UI
Posted by GitBox <gi...@apache.org>.
kobe860219 edited a comment on pull request #62:
URL: https://github.com/apache/incubator-yunikorn-web/pull/62#issuecomment-895773197
@yangwwei Hi, I removed ".travis.yaml" file and added "lint test". In "Build" stage of github action workflow, it will run `ng build --prod` as run `make build:prod` in travis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] kobe860219 edited a comment on pull request #62: [YUNIKORN-775] Create github action to build web UI
Posted by GitBox <gi...@apache.org>.
kobe860219 edited a comment on pull request #62:
URL: https://github.com/apache/incubator-yunikorn-web/pull/62#issuecomment-895773197
@yangwwei Hi, I removed ".travis.yaml" file and added "lint test". In "Build" stage of github action workflow, it will run `ng build --prod` as run `make build-prod` in travis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] yangwwei commented on pull request #62: [YUNIKORN-775] Create github action to build web UI
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #62:
URL: https://github.com/apache/incubator-yunikorn-web/pull/62#issuecomment-895740727
Also we need to remove `.travis.yml` file in this repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] kobe860219 commented on pull request #62: [YUNIKORN-775] Create github action to build web UI
Posted by GitBox <gi...@apache.org>.
kobe860219 commented on pull request #62:
URL: https://github.com/apache/incubator-yunikorn-web/pull/62#issuecomment-895773197
@yangwwei Hi, I removed .travis.yaml file and added lint test. In "Build" stage of github action workflow, it will run `ng build --prod` as run `make build:prod` in travis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org