[PATCH] enhancements made for apr under revision 331000

[al...@nextt.org]

objective:

  let apr compile with mingw properly

diff command used:

  diff -U1 -rw -x .svn apr apr-patch

attached files:

  apr-rev331000-20051105.patch (36347 bytes)

    patch generated by the diff command specified above

  apr-rev331000-20051105-new.tar.bz2 (4038 bytes)

    new files wich were not included in this patch to ease the analysis,
some may be only auxiliary.


Best regards,
Alexandre Girao

Re: [PATCH] enhancements made for apr under revision 331000

[Max Bowsher <ma...@ukf.net>]

alexandre@nextt.org wrote:
> objective:
>
>  let apr compile with mingw properly
>
> diff command used:
>
>  diff -U1 -rw -x .svn apr apr-patch
>
> attached files:
>
>  apr-rev331000-20051105.patch (36347 bytes)
>
>    patch generated by the diff command specified above
>
>  apr-rev331000-20051105-new.tar.bz2 (4038 bytes)
>
>    new files wich were not included in this patch to ease the analysis,
> some may be only auxiliary.


I noticed that almost 20% of Alexandre's patch is concerned exclusively with 
avoiding 'assignment used in if condition' warnings.

I've split that set of changes out from the rest, figuring that turning it 
into more easily digestible chunks would help speed the review process.

Max.

Re: [PATCH] enhancements made for apr under revision 331000

[Max Bowsher <ma...@ukf.net>]

alexandre@nextt.org wrote:
>  diff -U1 -rw -x .svn apr apr-patch

If you are working out of a Subversion working copy, you might as well take 
advantage of it:

$ svn diff --diff-cmd diff -x "-U1 -rw"

Max.