You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Jean-Louis MONTEIRO <je...@gmail.com> on 2011/07/26 17:14:29 UTC

Refactoring deps ...

Hi,

I manage to split (as we already discussed in another thread) javaee-api
into 2 jars:
- javaee-api containing all apis we can use in TomEE
- javaee-api-embedded when we don't need el, jsp and servlet


It works fine now but I saw a lot of duplicated information.
And as some of you know, I don't like duplicate information because we never
update in all places.

For example, the assemble building javaee-api-libs is not up to date at all.

Anyway, I wanted to try refactoring that in something better (IMO).
Here is a patch file.

Would be great if you can give your opinion.
Specially you Stephen (our Maven Guru).

http://openejb.979440.n4.nabble.com/file/n3696086/before-refactor-deps.patch
before-refactor-deps.patch 

Next step is to update some specs in regards to recent votes.

Thanks,
Jean-Louis

--
View this message in context: http://openejb.979440.n4.nabble.com/Refactoring-deps-tp3696086p3696086.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.

Re: Refactoring deps ...

Posted by David Blevins <da...@gmail.com>.
On Jul 26, 2011, at 8:14 AM, Jean-Louis MONTEIRO wrote:

> Hi,
> 
> I manage to split (as we already discussed in another thread) javaee-api
> into 2 jars:
> - javaee-api containing all apis we can use in TomEE
> - javaee-api-embedded when we don't need el, jsp and servlet

Fyi, it's in TomEE where we don't need el, jsp and servlet.  Everywhere else we do, such as embedded or standalone.

Seems the contents of the files are correct, but maybe the descriptions and the "-embedded" can be changed.

-David

> 
> It works fine now but I saw a lot of duplicated information.
> And as some of you know, I don't like duplicate information because we never
> update in all places.
> 
> For example, the assemble building javaee-api-libs is not up to date at all.
> 
> Anyway, I wanted to try refactoring that in something better (IMO).
> Here is a patch file.
> 
> Would be great if you can give your opinion.
> Specially you Stephen (our Maven Guru).
> 
> http://openejb.979440.n4.nabble.com/file/n3696086/before-refactor-deps.patch
> before-refactor-deps.patch 
> 
> Next step is to update some specs in regards to recent votes.
> 
> Thanks,
> Jean-Louis
> 
> --
> View this message in context: http://openejb.979440.n4.nabble.com/Refactoring-deps-tp3696086p3696086.html
> Sent from the OpenEJB Dev mailing list archive at Nabble.com.