You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/03/22 23:36:51 UTC
Review Request 70285: Implemented the remaining methods of v0
`VolumeManager`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70285/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Bugs: MESOS-9622
https://issues.apache.org/jira/browse/MESOS-9622
Repository: mesos
Description
-------
This patch completes the v0 `VolumeManager` by properly implemented the
`attachVolume`, `detachVolume` and `unpublishVolume` functions that are
not used by SLRP.
Diffs
-----
src/csi/v0_volume_manager.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/70285/diff/1/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 70285: Implemented the remaining methods of v0
`VolumeManager`.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70285/#review214054
-----------------------------------------------------------
Ship it!
Looks good, but it would be great to actually excercise and test this.
- Benjamin Bannier
On March 23, 2019, 12:36 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70285/
> -----------------------------------------------------------
>
> (Updated March 23, 2019, 12:36 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9622
> https://issues.apache.org/jira/browse/MESOS-9622
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch completes the v0 `VolumeManager` by properly implemented the
> `attachVolume`, `detachVolume` and `unpublishVolume` functions that are
> not used by SLRP.
>
>
> Diffs
> -----
>
> src/csi/v0_volume_manager.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/70285/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70285: Implemented the remaining methods of v0
`VolumeManager`.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70285/
-----------------------------------------------------------
(Updated March 27, 2019, 6:02 a.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Changes
-------
Rebased.
Bugs: MESOS-9622
https://issues.apache.org/jira/browse/MESOS-9622
Repository: mesos
Description
-------
This patch completes the v0 `VolumeManager` by properly implemented the
`attachVolume`, `detachVolume` and `unpublishVolume` functions that are
not used by SLRP.
Diffs (updated)
-----
src/csi/v0_volume_manager.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/70285/diff/2/
Changes: https://reviews.apache.org/r/70285/diff/1-2/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao