You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2025/05/28 17:17:00 UTC
[jira] [Commented] (IMPALA-14103) TestAdmissionControllerStress fails on Python 3 due to invalid except clause
[ https://issues.apache.org/jira/browse/IMPALA-14103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954644#comment-17954644 ]
ASF subversion and git services commented on IMPALA-14103:
----------------------------------------------------------
Commit 71b47dfdb483867f4a1ec5e250904659510e0ea8 in impala's branch refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=71b47dfdb ]
IMPALA-14103: Fix TestAdmissionControllerStress on Python 3
TestAdmissionControllerStress has an invalid except clause
where it catches Exception as well as ImpalaHiveServer2Service.
This is an error on Python 3, because ImpalaHiveServer2Service
is not an exception class. This changes the except clause to
only cause Exception.
Testing:
- Ran TestAdmissionControllerStress locally
Change-Id: Iefe9306cd6b76bd27ca5be1d62b05aff1e5deafe
Reviewed-on: http://gerrit.cloudera.org:8080/22954
Reviewed-by: Riza Suminto <ri...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
> TestAdmissionControllerStress fails on Python 3 due to invalid except clause
> ----------------------------------------------------------------------------
>
> Key: IMPALA-14103
> URL: https://issues.apache.org/jira/browse/IMPALA-14103
> Project: IMPALA
> Issue Type: Sub-task
> Components: Test
> Affects Versions: Impala 5.0.0
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Major
>
> When using IMPALA_USE_PYTHON3_TESTS=true, custom_cluster.test_admission_controller.TestAdmissionControllerStress fails with an error:
> {noformat}
> custom_cluster/test_admission_controller.py:2832: in test_admission_controller_with_configs
> self.run_admission_test(vector)
> custom_cluster/test_admission_controller.py:2805: in run_admission_test
> raise thread.error
> custom_cluster/test_admission_controller.py:2577: in run
> self._end_query(client, query, query_handle)
> custom_cluster/test_admission_controller.py:2616: in _end_query
> except (Exception, ImpalaHiveServer2Service) as e:
> E TypeError: catching classes that do not inherit from BaseException is not allowed{noformat}
> It's complaining about ImpalaHiveServer2Service, which is not an exception type. It looks like we might be able to remove that.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org