You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "iamhucong (via GitHub)" <gi...@apache.org> on 2023/06/16 10:24:01 UTC
[GitHub] [shardingsphere] iamhucong opened a new pull request, #26388: To improve the slow performance of OracleSchemaMetaDataLoader.loadColumnMetaDataMap, increase the result set fetch size.
iamhucong opened a new pull request, #26388:
URL: https://github.com/apache/shardingsphere/pull/26388
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuichenchuxin commented on a diff in pull request #26388: Fix the issue with e2e.
Posted by "tuichenchuxin (via GitHub)" <gi...@apache.org>.
tuichenchuxin commented on code in PR #26388:
URL: https://github.com/apache/shardingsphere/pull/26388#discussion_r1236451852
##########
test/e2e/sql/src/test/resources/env/scenario/tbl/proxy/conf/mysql/config-tbl.yaml:
##########
@@ -108,3 +108,6 @@ rules:
tables:
- t_broadcast_table
- t_broadcast_table_for_ddl
+
+- !SQL_PARSER
+ sqlCommentParseEnabled: true
Review Comment:
better add new line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia merged pull request #26388: Fix the issue with e2e.
Posted by "taojintianxia (via GitHub)" <gi...@apache.org>.
taojintianxia merged PR #26388:
URL: https://github.com/apache/shardingsphere/pull/26388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org