You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/07/23 13:17:59 UTC
[GitHub] chickenlj commented on a change in pull request #2114: Dubbo-2013
chickenlj commented on a change in pull request #2114: Dubbo-2013
URL: https://github.com/apache/incubator-dubbo/pull/2114#discussion_r204396641
##########
File path: dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ConsumerConfig.java
##########
@@ -31,6 +31,9 @@
// networking framework client uses: netty, mina, etc.
private String client;
+ // client thread pool type: cached, fixed, limit, eager
+ private String threadpool;
Review comment:
We may also need the following two parameters:
```xml
<xsd:attribute name="threads" type="xsd:string" use="optional">
<xsd:annotation>
<xsd:documentation><![CDATA[ The thread pool size. ]]></xsd:documentation>
</xsd:annotation>
</xsd:attribute>
<xsd:attribute name="queues" type="xsd:string" use="optional">
<xsd:annotation>
<xsd:documentation><![CDATA[ The thread pool queue size. ]]></xsd:documentation>
</xsd:annotation>
</xsd:attribute>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org