You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by artem-aliev <gi...@git.apache.org> on 2017/07/17 11:28:11 UTC
[GitHub] tinkerpop pull request #678: TINKERPOP-1715: update spark version to 2.2
GitHub user artem-aliev opened a pull request:
https://github.com/apache/tinkerpop/pull/678
TINKERPOP-1715: update spark version to 2.2
That required:
- more spark conflicting dependency exclusion in pom.xml
- more spark and scala classes registration in tinkerPop gryo
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/artem-aliev/tinkerpop TINKERPOP-1715
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/678.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #678
----
commit 9e8cc5a1b2893d9aab9da76dee61e3604ce7aadc
Author: artemaliev <artem.aliev@gmail,com>
Date: 2017-07-17T10:55:45Z
TINKERPOP-1715: update spark version to 2.2
That required:
- more spark conflicting dependency exclusion in pom.xml
- more spark and scala classes registration in tinkerPop gryo
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #678: TINKERPOP-1715: update spark version to 2.2
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/678#discussion_r127686608
--- Diff: gremlin-groovy/pom.xml ---
@@ -93,6 +93,10 @@ limitations under the License.
<version>${project.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
--- End diff --
any reason why adding junit here was necessary?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #678: TINKERPOP-1715: update spark version to 2.2
Posted by davebshow <gi...@git.apache.org>.
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/678
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #678: TINKERPOP-1715: update spark version to 2.2
Posted by artem-aliev <gi...@git.apache.org>.
Github user artem-aliev commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/678#discussion_r127710343
--- Diff: gremlin-groovy/pom.xml ---
@@ -93,6 +93,10 @@ limitations under the License.
<version>${project.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
--- End diff --
Hm, It was needed for build.....
Now I can not reproduce the failure, so rollback it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #678: TINKERPOP-1715: update spark version to 2.2
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/678
All tests pass with `docker/build.sh -t -i`
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #678: TINKERPOP-1715: update spark version to 2.2
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/678
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #678: TINKERPOP-1715: update spark version to 2.2
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/678
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---