[jira] [Commented] (AIRFLOW-5873) KubernetesPodOperator fixes and test

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970114#comment-16970114 ] 

ASF GitHub Bot commented on AIRFLOW-5873:
-----------------------------------------

ddelange commented on pull request #6523: [AIRFLOW-5873] KubernetesPodOperator fixes and test
URL: https://github.com/apache/airflow/pull/6523
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira]
     - https://issues.apache.org/jira/browse/AIRFLOW-5873
   
   ### Description
   
   - `KubernetesPodOperator` kwarg `resources` is erroneously passed to `base_operator`, instead should only go to `PodGenerator`. The two have different syntax. (both on `master` and `v1-10-test` branches)
   - `KubernetesPodOperator` kwarg `in_cluster` erroneously defaults to False in comparison to `default_args.py`
   - `kubernetes/pod.py`: `Resources` does not have `__slots__` so accepts arbitrary values in `setattr` (present on `v1-10-test` branch https://github.com/apache/airflow/blame/v1-10-test/airflow/contrib/operators/kubernetes_pod_operator.py#L166)
   - `v1-10-test` is behind `master` with KubernetesPodOperator fixes and refactors
     - e.g. move kubernetes folder one level up from `/contrib` https://github.com/apache/airflow/blame/4dd24a2c595d4042ffe745aed947eaaea6abb652/airflow/contrib/operators/kubernetes_pod_operator.py#L21
     - fix `xcom_push` to `do_xcom_push` https://github.com/apache/airflow/blame/4dd24a2c595d4042ffe745aed947eaaea6abb652/airflow/contrib/operators/kubernetes_pod_operator.py#L90
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   `contrib/operators/test_kubernetes_pod_operator.py`
   
   <!-- ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release -->
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> KubernetesPodOperator fixes and test
> ------------------------------------
>
>                 Key: AIRFLOW-5873
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5873
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: operators
>    Affects Versions: 1.10.6
>            Reporter: David de L.
>            Assignee: David de L.
>            Priority: Major
>             Fix For: 1.10.7
>
>
> * `KubernetesPodOperator` kwarg `resources` is erroneously passed to `base_operator`, instead should only go to `PodGenerator`. The two have different syntax. (both on `master` and `v1-10-test` branches)
>  * `KubernetesPodOperator` kwarg `in_cluster` erroneously defaults to False in comparison to `default_args.py`
>  * `kubernetes/pod.py`: `Resources` does not have `__slots__` so accepts arbitrary values in `setattr` (present on `v1-10-test` branch [https://github.com/apache/airflow/blame/v1-10-test/airflow/contrib/operators/kubernetes_pod_operator.py#L166])
>  * `v1-10-test` is behind `master` with KubernetesPodOperator fixes and refactors
>  ** e.g. move kubernetes folder one level up from `/contrib` [https://github.com/apache/airflow/blame/4dd24a2c595d4042ffe745aed947eaaea6abb652/airflow/contrib/operators/kubernetes_pod_operator.py#L21]
>  ** fix `xcom_push` to `do_xcom_push` [https://github.com/apache/airflow/blame/4dd24a2c595d4042ffe745aed947eaaea6abb652/airflow/contrib/operators/kubernetes_pod_operator.py#L90]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)