You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "harshithasudhakar (via GitHub)" <gi...@apache.org> on 2023/05/07 18:26:48 UTC
[GitHub] [eventmesh] harshithasudhakar opened a new pull request, #3883: [ISSUE #3472]Do some code optimization[HttpProtocolAdaptor
harshithasudhakar opened a new pull request, #3883:
URL: https://github.com/apache/eventmesh/pull/3883
Fixes #3472
### Modifications
1.
imported `java.util.Collections`
returns `Collections.emptyList()` at line 81.
2. Used `Objects.requireNonNull()` at line 103
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #3472]Do some code optimization[HttpProtocolAdaptor] (eventmesh)
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo merged PR #3883:
URL: https://github.com/apache/eventmesh/pull/3883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3883: [ISSUE #3472]Do some code optimization[HttpProtocolAdaptor]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3883:
URL: https://github.com/apache/eventmesh/pull/3883#issuecomment-1539600965
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3883?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3883](https://app.codecov.io/gh/apache/eventmesh/pull/3883?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2cc7864) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/e1e9acab09291b2eb10f1a88ee28dd0103bf26a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e1e9aca) will **decrease** coverage by `0.02%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 2cc7864 differs from pull request most recent head 424a9af. Consider uploading reports for the commit 424a9af to get more accurate results
```diff
@@ Coverage Diff @@
## master #3883 +/- ##
============================================
- Coverage 13.93% 13.92% -0.02%
Complexity 1291 1291
============================================
Files 570 570
Lines 28847 28840 -7
Branches 2811 2799 -12
============================================
- Hits 4019 4015 -4
+ Misses 24455 24453 -2
+ Partials 373 372 -1
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/eventmesh/protocol/http/HttpProtocolAdaptor.java](https://app.codecov.io/gh/apache/eventmesh/pull/3883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXByb3RvY29sLXBsdWdpbi9ldmVudG1lc2gtcHJvdG9jb2wtaHR0cC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL3Byb3RvY29sL2h0dHAvSHR0cFByb3RvY29sQWRhcHRvci5qYXZh) | `5.26% <0.00%> (ø)` | |
... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/3883/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] Alonexc commented on a diff in pull request #3883: [ISSUE #3472]Do some code optimization[HttpProtocolAdaptor]
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on code in PR #3883:
URL: https://github.com/apache/eventmesh/pull/3883#discussion_r1186959780
##########
eventmesh-protocol-plugin/eventmesh-protocol-http/src/main/java/org/apache/eventmesh/protocol/http/HttpProtocolAdaptor.java:
##########
@@ -37,6 +37,7 @@
import java.util.Map;
import java.util.Objects;
import java.util.Set;
+import java.util.Collections;
Review Comment:
This import should be placed here:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org