[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #14475: KCA: Option to sanitize topic name for the connectors that cannot handle pulsar topic names

[GitBox <gi...@apache.org>]

michaeljmarshall commented on a change in pull request #14475:
URL: https://github.com/apache/pulsar/pull/14475#discussion_r816180780



##########
File path: pulsar-io/kafka-connect-adaptor/src/main/java/org/apache/pulsar/io/kafka/connect/PulsarKafkaConnectSinkConfig.java
##########
@@ -73,6 +73,14 @@
             help = "In case of Record<KeyValue<>> data use key from KeyValue<> instead of one from Record.")
     private boolean unwrapKeyValueIfAvailable = true;
 
+    @FieldDoc(
+            defaultValue = "false",
+            help = "Some connectors cannot handle pulsar topic names like persistent://a/b/topic"
+                    + " and do not sanitize the topic name themselves. \n"
+                    + "If enabled, all non alpha-digital characters in topic name will be replaced with underscores. \n"
+                    + "In some cases it may result in topic name collisions (topic_a and topic.a will become the same)")
+    private boolean sanitizeTopicName = false;

Review comment:
       It might be worth adding a note in the `topic` field to describe how `sanitizeTopicName` can be used to address valid Pulsar topic names that are invalid in Kafka.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org