You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Zhongbo Tian <wi...@gmail.com> on 2012/07/11 05:25:57 UTC
Review Request: Patch to fix leak in libprocess
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5904/
-----------------------------------------------------------
Review request for mesos.
Description
-------
It seems that libprocess has memory-leaking problem.
When state is not in pending, refs will be decreased an extra time to become -1, and then memory leaked.
So the solution I proposed is that guard the discard function with a pair of increament/decrement of refs,
and it will be safe to verify if refs is zero out of the guard scope.
Diffs
-----
third_party/libprocess/include/process/future.hpp 1aa8ffd
Diff: https://reviews.apache.org/r/5904/diff/
Testing
-------
Test is done in our deployment enviroment, and seems all right.
Thanks,
Zhongbo Tian
Re: Review Request: Patch to fix leak in libprocess
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5904/#review9295
-----------------------------------------------------------
Ship it!
This is fantastic! Thanks so much!
- Benjamin Hindman
On July 11, 2012, 3:34 a.m., Zhongbo Tian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5904/
> -----------------------------------------------------------
>
> (Updated July 11, 2012, 3:34 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> It seems that libprocess has memory-leaking problem.
> When state is not in pending, refs will be decreased an extra time to become -1, and then memory leaked.
> So the solution I proposed is that guard the discard function with a pair of increament/decrement of refs,
> and it will be safe to verify if refs is zero out of the guard scope.
>
>
> Diffs
> -----
>
> third_party/libprocess/include/process/future.hpp 1aa8ffd
>
> Diff: https://reviews.apache.org/r/5904/diff/
>
>
> Testing
> -------
>
> Test is done in our deployment enviroment, and seems all right.
>
>
> Thanks,
>
> Zhongbo Tian
>
>
Re: Review Request: Patch to fix leak in libprocess
Posted by Zhongbo Tian <wi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5904/
-----------------------------------------------------------
(Updated July 11, 2012, 3:34 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
It seems that libprocess has memory-leaking problem.
When state is not in pending, refs will be decreased an extra time to become -1, and then memory leaked.
So the solution I proposed is that guard the discard function with a pair of increament/decrement of refs,
and it will be safe to verify if refs is zero out of the guard scope.
Diffs
-----
third_party/libprocess/include/process/future.hpp 1aa8ffd
Diff: https://reviews.apache.org/r/5904/diff/
Testing
-------
Test is done in our deployment enviroment, and seems all right.
Thanks,
Zhongbo Tian