You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2020/11/27 08:43:54 UTC
[Bug 64938] New: response.setCharacterEncoding(null) should clear
previous charset
https://bz.apache.org/bugzilla/show_bug.cgi?id=64938
Bug ID: 64938
Summary: response.setCharacterEncoding(null) should clear
previous charset
Product: Tomcat 9
Version: unspecified
Hardware: PC
OS: Mac OS X 10.4
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
Assignee: dev@tomcat.apache.org
Reporter: zhouyanming@gmail.com
Target Milestone: -----
I have a filter set response charset to UTF-8 globally, one of my servlets want
remove charset encoding from response Content-Type, for example
response.setCharacterEncoding(null);
response.setContentType("application/wasm");
It still generate invalid "application/wasm;charset=UTF-8" because
"response.setCharacterEncoding(null)" is noop, currently there is no way to
clear previous charset.
https://github.com/apache/tomcat/blob/master/java/org/apache/coyote/Response.java#L502
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 64938] response.setCharacterEncoding(null) should clear
previous charset
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64938
--- Comment #3 from Remy Maucherat <re...@apache.org> ---
According to the javadoc, null is probably not a valid value (it says:
"charset: a String specifying only the character set defined by IANA", so
"null" is obviously not one of these). Unlike other places, it is not specified
to throw an IAE or something like that.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 64938] response.setCharacterEncoding(null) should clear
previous charset
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64938
--- Comment #1 from quaff <zh...@gmail.com> ---
Jetty is respect this
https://github.com/eclipse/jetty.project/blob/jetty-10.0.x/jetty-server/src/main/java/org/eclipse/jetty/server/Response.java#L1000
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 64938] response.setCharacterEncoding(null) should clear
previous charset
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64938
--- Comment #6 from Mark Thomas <ma...@apache.org> ---
I've implemented the changes agreed in the Jakarta Servlet project for 10.0.x.
They will be in 10.0.3 onwards.
I have started a discussion on the dev@ list to determine if the changes should
be back-ported and how configurable - if at all - they should be in earlier
versions.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 64938] response.setCharacterEncoding(null) should clear
previous charset
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64938
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |NEW
--- Comment #5 from Mark Thomas <ma...@apache.org> ---
The spec project has provided clarification via updated Javadoc. Strictly that
only applies to the next iteration of the Servlet spec but do I intend to look
at applying this to current Tomcat versions.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 64938] response.setCharacterEncoding(null) should clear
previous charset
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64938
--- Comment #2 from Mark Thomas <ma...@apache.org> ---
The behaviour of other Servlet containers is irrelevant. What matters is the
Sevlet specification.
You could argue that the ServletResponse.setCharacterEncoding Javadoc does not
permit null to be passed as the character set. Neither does it define the
failure mode if an invalid character encoding is specified. This is one of the
many areas where the spec could be better defined.
One workaround may be to define the default character encoding in web.xml with:
<response-character-encoding>UTF-8</response-character-encoding>
rather than via the filter. Although that won't help if some resources require
UTF-8 to be set explicitly.
Another possible workaround is ServletResponse.reset().
The interplay of setLocale(), setContentType() and setChjaracterEncoding()
along with getWriter() and the web.xml default encoding (and probably at least
one other bit I have forgotten) means that this might not be as simple as it
first looks.
I can see the use case for being able to use null here so I'm planning on
looking at this later today with a view to implementing it. I'll also see if we
can get the Javadoc clarified that null undoes any previous call (assuming
getWriter() hasn't been called etc.)
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 64938] response.setCharacterEncoding(null) should clear
previous charset
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64938
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #4 from Mark Thomas <ma...@apache.org> ---
The current Javadoc certainly implies null is not valid here but I can see how
allowing it might be useful.
I've opened https://github.com/eclipse-ee4j/servlet-api/issues/377
Switching to NEEDINFO as the way forward will be guided by how the spec project
decides to clarify this.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 64938] response.setCharacterEncoding(null) should clear
previous charset
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64938
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #7 from Mark Thomas <ma...@apache.org> ---
Fixed in:
- 10.0.x for 10.0.3 onwards
- 9.0.x for 9.0.44 onwards
- 8.5.x for 8.5.64 onwards
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org