You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by mureinik <gi...@git.apache.org> on 2017/02/27 19:40:35 UTC

[GitHub] commons-lang pull request #246: DateUtilsTest asserts

GitHub user mureinik opened a pull request:

    https://github.com/apache/commons-lang/pull/246

    DateUtilsTest asserts

    Use JUnit's assertFalse for assertions with conditions instead of
    re-implementing the logic here by testing the condition and throwing an
    AssertionFailureException if the condition is met.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mureinik/commons-lang DateUtilsTest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/246.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #246
    
----
commit 59effed7ad53df5a59bee8b09b8e21ba9900156b
Author: Allon Mureinik <am...@redhat.com>
Date:   2017-02-27T19:35:03Z

    DateUtilsTest asserts
    
    Use JUnit's assertFalse for assertions with conditions instead of
    re-implementing the logic here by testing the condition and throwing an
    AssertionFailureException if the condition is met.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #246: DateUtilsTest asserts

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/commons-lang/pull/246


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #246: DateUtilsTest asserts

Posted by kinow <gi...@git.apache.org>.

Github user kinow commented on the issue:

    https://github.com/apache/commons-lang/pull/246
  
    :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #246: DateUtilsTest asserts

Posted by PascalSchumacher <gi...@git.apache.org>.

Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-lang/pull/246
  
    Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---