You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/26 17:09:36 UTC
[GitHub] [airflow] potiuk opened a new pull request #15534: Make Airflow code Pylint 2.8 compatible
potiuk opened a new pull request #15534:
URL: https://github.com/apache/airflow/pull/15534
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #15534: Make Airflow code Pylint 2.8 compatible
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #15534:
URL: https://github.com/apache/airflow/pull/15534#discussion_r620500075
##########
File path: airflow/providers/apache/beam/hooks/beam.py
##########
@@ -94,6 +94,7 @@ def __init__(
self.log.info("Running command: %s", " ".join(shlex.quote(c) for c in cmd))
self.process_line_callback = process_line_callback
self.job_id: Optional[str] = None
+ # pylint: disable=consider-using-with
Review comment:
This is a bit sad because this class should be a function. We don't need to keep the state here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #15534: Make Airflow code Pylint 2.8 compatible
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #15534:
URL: https://github.com/apache/airflow/pull/15534#discussion_r620504753
##########
File path: airflow/providers/apache/beam/hooks/beam.py
##########
@@ -94,6 +94,7 @@ def __init__(
self.log.info("Running command: %s", " ".join(shlex.quote(c) for c in cmd))
self.process_line_callback = process_line_callback
self.job_id: Optional[str] = None
+ # pylint: disable=consider-using-with
Review comment:
I created issue for it https://github.com/apache/airflow/issues/15536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #15534: Make Airflow code Pylint 2.8 compatible
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #15534:
URL: https://github.com/apache/airflow/pull/15534#discussion_r620502100
##########
File path: airflow/providers/apache/beam/hooks/beam.py
##########
@@ -94,6 +94,7 @@ def __init__(
self.log.info("Running command: %s", " ".join(shlex.quote(c) for c in cmd))
self.process_line_callback = process_line_callback
self.job_id: Optional[str] = None
+ # pylint: disable=consider-using-with
Review comment:
Possibly we can rewrite it, but this can be done separately. I wanted to keep minimal/safe set of changes to make it works without risking backwards compatibility/unforeseen side effects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15534: Make Airflow code Pylint 2.8 compatible
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15534:
URL: https://github.com/apache/airflow/pull/15534#issuecomment-827022088
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #15534: Make Airflow code Pylint 2.8 compatible
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #15534:
URL: https://github.com/apache/airflow/pull/15534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #15534: Make Airflow code Pylint 2.8 compatible
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #15534:
URL: https://github.com/apache/airflow/pull/15534#discussion_r620501862
##########
File path: airflow/providers/apache/beam/hooks/beam.py
##########
@@ -94,6 +94,7 @@ def __init__(
self.log.info("Running command: %s", " ".join(shlex.quote(c) for c in cmd))
self.process_line_callback = process_line_callback
self.job_id: Optional[str] = None
+ # pylint: disable=consider-using-with
Review comment:
This class is only used once in Airflow code and the method of that class is called immediately after that, so converting it to a regular function shouldn't be difficult.
https://github.com/apache/airflow/blob/d598630cd7a2e80fd84c499cfcba37ad2b6888f3/airflow/providers/apache/beam/hooks/beam.py#L181-L185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org