You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Julius Davies <ju...@gmail.com> on 2009/07/27 03:08:20 UTC
[codec] - CODEC-59 and CODEC-81
I have a patch ready for CODEC-59, but I'm going to wait until
CODEC-81 is either accepted or rejected first, since there's a bit of
conflict between these two patches, and my brain is not working well
enough right now to sort these issues out ahead of time.
CODEC-81 is an actual bug-fix for TRUNK / 1.4-RC2 so I'd be surprised
if it wasn't accepted in some shape or form, whereas the CODEC-59
patch will be an enhancement.
--
yours,
Julius Davies
250-592-2284 (Home)
250-893-4579 (Mobile)
http://juliusdavies.ca/logging.html
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [codec] - CODEC-59 and CODEC-81
Posted by Julius Davies <ju...@gmail.com>.
Hi, Gary,
I just attached a [CODEC-59] patch that I think I'm finally happy
with. This one is based on trunk as of right now.
I've also added a private reset() call that encode() and decode()
always call just before they start their operation. The reset() makes
this kind of usage possible:
Base64 b64 = new Base64();
b64.encode(someThing);
b64.encode(someOtherThing);
Unfortunately the [CODEC-81] patch made this impossible (re-using same
Base64 object for different encodes or decodes). Note: Base64's
static methods are thread safe, but the instance methods are not. If
we decide to leave [CODEC-59] out of a 1.4 release, I'll create a
separate ticket just for this reset() issue.
yours,
Julius
> Julius:
>
> Patch for [CODEC-81] is in and then some.
>
> Thank you for the submission. Keep them coming.
>
> Gary
>
--
yours,
Julius Davies
250-592-2284 (Home)
250-893-4579 (Mobile)
http://juliusdavies.ca/logging.html
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
RE: [codec] - CODEC-59 and CODEC-81
Posted by Gary Gregory <GG...@seagullsoftware.com>.
> -----Original Message-----
> From: Julius Davies [mailto:juliusdavies@gmail.com]
> Sent: Monday, July 27, 2009 11:50 AM
> To: Commons Developers List
> Subject: Re: [codec] - CODEC-59 and CODEC-81
>
> Very sorry! New patch uploaded.
>
> yours,
>
> Julius
Julius:
Patch for [CODEC-81] is in and then some.
Thank you for the submission. Keep them coming.
Gary
>
> On Mon, Jul 27, 2009 at 12:11 AM, Gary
> Gregory<GG...@seagullsoftware.com> wrote:
> > Hi Julius,
> >
> > The new test patch in CODEC-59 contains a call to a Java 1.5 API so I
> cannot apply it. We are on Java 1.4.2 for codec 1.4. Can you please
> provide a reworked patch?
> >
> > Thank you,
> > Gary
> >
> >> -----Original Message-----
> >> From: Julius Davies [mailto:juliusdavies@gmail.com]
> >> Sent: Sunday, July 26, 2009 6:08 PM
> >> To: Commons Developers List
> >> Subject: [codec] - CODEC-59 and CODEC-81
> >>
> >> I have a patch ready for CODEC-59, but I'm going to wait until
> >> CODEC-81 is either accepted or rejected first, since there's a bit of
> >> conflict between these two patches, and my brain is not working well
> >> enough right now to sort these issues out ahead of time.
> >>
> >> CODEC-81 is an actual bug-fix for TRUNK / 1.4-RC2 so I'd be surprised
> >> if it wasn't accepted in some shape or form, whereas the CODEC-59
> >> patch will be an enhancement.
> >>
> >> --
> >> yours,
> >>
> >> Julius Davies
> >> 250-592-2284 (Home)
> >> 250-893-4579 (Mobile)
> >> http://juliusdavies.ca/logging.html
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
>
>
> --
> yours,
>
> Julius Davies
> 250-592-2284 (Home)
> 250-893-4579 (Mobile)
> http://juliusdavies.ca/logging.html
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [codec] - CODEC-59 and CODEC-81
Posted by Julius Davies <ju...@gmail.com>.
Very sorry! New patch uploaded.
yours,
Julius
On Mon, Jul 27, 2009 at 12:11 AM, Gary
Gregory<GG...@seagullsoftware.com> wrote:
> Hi Julius,
>
> The new test patch in CODEC-59 contains a call to a Java 1.5 API so I cannot apply it. We are on Java 1.4.2 for codec 1.4. Can you please provide a reworked patch?
>
> Thank you,
> Gary
>
>> -----Original Message-----
>> From: Julius Davies [mailto:juliusdavies@gmail.com]
>> Sent: Sunday, July 26, 2009 6:08 PM
>> To: Commons Developers List
>> Subject: [codec] - CODEC-59 and CODEC-81
>>
>> I have a patch ready for CODEC-59, but I'm going to wait until
>> CODEC-81 is either accepted or rejected first, since there's a bit of
>> conflict between these two patches, and my brain is not working well
>> enough right now to sort these issues out ahead of time.
>>
>> CODEC-81 is an actual bug-fix for TRUNK / 1.4-RC2 so I'd be surprised
>> if it wasn't accepted in some shape or form, whereas the CODEC-59
>> patch will be an enhancement.
>>
>> --
>> yours,
>>
>> Julius Davies
>> 250-592-2284 (Home)
>> 250-893-4579 (Mobile)
>> http://juliusdavies.ca/logging.html
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
yours,
Julius Davies
250-592-2284 (Home)
250-893-4579 (Mobile)
http://juliusdavies.ca/logging.html
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
RE: [codec] - CODEC-59 and CODEC-81
Posted by Gary Gregory <GG...@seagullsoftware.com>.
Hi Julius,
The new test patch in CODEC-59 contains a call to a Java 1.5 API so I cannot apply it. We are on Java 1.4.2 for codec 1.4. Can you please provide a reworked patch?
Thank you,
Gary
> -----Original Message-----
> From: Julius Davies [mailto:juliusdavies@gmail.com]
> Sent: Sunday, July 26, 2009 6:08 PM
> To: Commons Developers List
> Subject: [codec] - CODEC-59 and CODEC-81
>
> I have a patch ready for CODEC-59, but I'm going to wait until
> CODEC-81 is either accepted or rejected first, since there's a bit of
> conflict between these two patches, and my brain is not working well
> enough right now to sort these issues out ahead of time.
>
> CODEC-81 is an actual bug-fix for TRUNK / 1.4-RC2 so I'd be surprised
> if it wasn't accepted in some shape or form, whereas the CODEC-59
> patch will be an enhancement.
>
> --
> yours,
>
> Julius Davies
> 250-592-2284 (Home)
> 250-893-4579 (Mobile)
> http://juliusdavies.ca/logging.html
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org