You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/11/11 19:52:16 UTC

[GitHub] emilianbold commented on a change in pull request #1007: [NETBEANS-1605] Removed NetBeans max HeapSize heuristics.

emilianbold commented on a change in pull request #1007: [NETBEANS-1605] Removed NetBeans max HeapSize heuristics.
URL: https://github.com/apache/incubator-netbeans/pull/1007#discussion_r232501855
 
 

 ##########
 File path: nb/ide.launcher/windows/nblauncher.h
 ##########
 @@ -64,7 +64,6 @@ class NbLauncher {
     virtual bool initBaseNames();
     virtual void addSpecificOptions(CmdArgs &args);
     virtual bool areWeOn32bits();
 
 Review comment:
   `areWeOn32bits` seems to exist just for `adjustHeapAndPermGenSize` so you should delete that one too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists