You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mimaison (via GitHub)" <gi...@apache.org> on 2024/05/21 17:26:06 UTC
[PR] MINOR: Move Throttler to storage module [kafka]
mimaison opened a new pull request, #16023:
URL: https://github.com/apache/kafka/pull/16023
Throttler is one of the dependencies required in order to move LogCleaner out of core.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Move Throttler to storage module [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #16023:
URL: https://github.com/apache/kafka/pull/16023#issuecomment-2125286981
None of the test failures seem related, merging to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Move Throttler to storage module [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on code in PR #16023:
URL: https://github.com/apache/kafka/pull/16023#discussion_r1609586011
##########
core/src/main/scala/kafka/log/LogCleaner.scala:
##########
@@ -109,12 +110,12 @@ class LogCleaner(initialConfig: CleanerConfig,
private[log] val cleanerManager = new LogCleanerManager(logDirs, logs, logDirFailureChannel)
/* a throttle used to limit the I/O of all the cleaner threads to a user-specified maximum rate */
- private[log] val throttler = new Throttler(desiredRatePerSec = config.maxIoBytesPerSecond,
- checkIntervalMs = 300,
- throttleDown = true,
- "cleaner-io",
- "bytes",
- time = time)
+ private[log] val throttler = new Throttler(config.maxIoBytesPerSecond,
+ 300,
+ true,
Review Comment:
Right this can be removed. Done.
I also removed the spotbugs exclusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Move Throttler to storage module [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #16023:
URL: https://github.com/apache/kafka/pull/16023#discussion_r1608736058
##########
core/src/main/scala/kafka/log/LogCleaner.scala:
##########
@@ -109,12 +110,12 @@ class LogCleaner(initialConfig: CleanerConfig,
private[log] val cleanerManager = new LogCleanerManager(logDirs, logs, logDirFailureChannel)
/* a throttle used to limit the I/O of all the cleaner threads to a user-specified maximum rate */
- private[log] val throttler = new Throttler(desiredRatePerSec = config.maxIoBytesPerSecond,
- checkIntervalMs = 300,
- throttleDown = true,
- "cleaner-io",
- "bytes",
- time = time)
+ private[log] val throttler = new Throttler(config.maxIoBytesPerSecond,
+ 300,
+ true,
Review Comment:
It seems `throttleDown` is always true in production. Maybe we can remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Move Throttler to storage module [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison merged PR #16023:
URL: https://github.com/apache/kafka/pull/16023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org