You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/24 12:36:35 UTC

[GitHub] [incubator-nuttx] pkarashchenko edited a comment on pull request #5323: Fix opensbi build

pkarashchenko edited a comment on pull request #5323:
URL: https://github.com/apache/incubator-nuttx/pull/5323#issuecomment-1020051647


   > I guess what happens is that if one modifies mpfs_opensbi.c -file, and builds, the OpenSBI patch has no #defined values yet, so the conflict is opposite: those #ifndefs would need to be in both headers... non-clean build fails or the warnings are present also with my setup.
   
   Yes. I'm filling the issue in opensbi github and will start a discussion. Probably the best way will be to add `SBI_` or `OPEN_SBI_` prefix, so the build will be clean.
   What I'm pointing here in comments there seems like there are many headers included that really are not needed for `mpfs_opensbi.c` to build


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org