You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/16 04:54:17 UTC

[GitHub] [pulsar] nodece opened a new pull request, #15616: [cleanup][dependency] Remove JUnit

nodece opened a new pull request, #15616:
URL: https://github.com/apache/pulsar/pull/15616

   Signed-off-by: Zixuan Liu <no...@gmail.com>
   
   ### Motivation
   
   We no longer use JUnit, so remove this.
   
   ### Modifications
   
   - Remove Junit dependency
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [x] `no-need-doc` 
   (Please explain why)
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-added`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nodece commented on pull request #15616: [cleanup][dependency] Remove JUnit

Posted by GitBox <gi...@apache.org>.
nodece commented on PR #15616:
URL: https://github.com/apache/pulsar/pull/15616#issuecomment-1127332397

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #15616: [cleanup][dependency] Remove JUnit

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15616:
URL: https://github.com/apache/pulsar/pull/15616#issuecomment-1170673109

   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nodece commented on pull request #15616: [cleanup][dependency] Remove JUnit

Posted by GitBox <gi...@apache.org>.
nodece commented on PR #15616:
URL: https://github.com/apache/pulsar/pull/15616#issuecomment-1134290392

   Hi @codelipenghui, this PR looks can be merged into the master branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nodece commented on pull request #15616: [cleanup][dependency] Remove JUnit

Posted by GitBox <gi...@apache.org>.
nodece commented on PR #15616:
URL: https://github.com/apache/pulsar/pull/15616#issuecomment-1127782586

   @codelipenghui I noticed this CI always failed, could you help me check this CI? Why does removing Junit break integration testing?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nodece commented on pull request #15616: [cleanup][dependency] Remove JUnit

Posted by GitBox <gi...@apache.org>.
nodece commented on PR #15616:
URL: https://github.com/apache/pulsar/pull/15616#issuecomment-1127321374

   /pulsarbot rerun-failure-chekcs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shoothzj commented on pull request #15616: [cleanup][dependency] Remove JUnit

Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #15616:
URL: https://github.com/apache/pulsar/pull/15616#issuecomment-1129464863

   pom file is changed, trigger the CVE check. One of the failure of CVE check needs to bump the grpc version. But `grpc` haven't release a version yet.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nodece commented on pull request #15616: [cleanup][dependency] Remove JUnit

Posted by GitBox <gi...@apache.org>.
nodece commented on PR #15616:
URL: https://github.com/apache/pulsar/pull/15616#issuecomment-1129496992

   Thanks @codelipenghui and @Shoothzj, the CI has been passed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #15616: [cleanup][dependency] Remove JUnit

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on PR #15616:
URL: https://github.com/apache/pulsar/pull/15616#issuecomment-1129455021

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nodece merged pull request #15616: [cleanup][dependency] Remove JUnit

Posted by GitBox <gi...@apache.org>.
nodece merged PR #15616:
URL: https://github.com/apache/pulsar/pull/15616


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org