[GitHub] [iceberg] Fokko commented on a diff in pull request #5467: Python: Add support for hierarchical namespaces

[GitBox <gi...@apache.org>]

Fokko commented on code in PR #5467:
URL: https://github.com/apache/iceberg/pull/5467#discussion_r943382896


##########
python/tests/catalog/test_rest.py:
##########
@@ -139,7 +139,7 @@ def test_list_tables_404(rest_mock: Mocker):
 
 def test_list_namespaces_200(rest_mock: Mocker):
     rest_mock.get(
-        f"{TEST_URI}v1/namespaces",
+        f"{TEST_URI}v1/namespaces?parent=",

Review Comment:
   I don't think there is such a thing as a `""` namespace in the spec, since you wouldn't be able to fetch the properties that namespace: `/v1/{prefix}/namespaces//properties:`. I've updated the code to have this distinction.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org