[GitHub] [samza] prateekm commented on a change in pull request #1003: Removing job.diagnostics.appender.class config, and populating it based on if log4j or log4j2 is class-loaded

[GitBox <gi...@apache.org>]

prateekm commented on a change in pull request #1003: Removing job.diagnostics.appender.class config, and populating it based on if log4j or log4j2 is class-loaded
URL: https://github.com/apache/samza/pull/1003#discussion_r276855830
 
 

 ##########
 File path: samza-core/src/main/scala/org/apache/samza/util/Util.scala
 ##########
 @@ -62,6 +62,21 @@ object Util extends Logging {
     }
   }
 
+  /**
+    * Instantiate an object from given className, and given constructor parameters.
+    */
+  def getObj(className: String, constructorParameterTypes: (Class[_], Object)*) = {
 
 Review comment:
   As a general util method, I think it makes more sense for this to throw instead for returning an Option. You can then catch at your call site. 
   Should also add explicit return type for public methods.
   Maybe s/contructorParamaterTypes/constructorParams

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services