You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/10/21 22:18:03 UTC
[kudu-CR] KUDU-2982: Document taking backups on earlier versions of Kudu
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14525
Change subject: KUDU-2982: Document taking backups on earlier versions of Kudu
......................................................................
KUDU-2982: Document taking backups on earlier versions of Kudu
Adds a section to the backup documentation describing how to
succesfully take backups on Kudu clusters earlier than Kudu 1.10.
Change-Id: I15201bafc5c0e40b230873f92790d4fc2a02bdde
---
M docs/administration.adoc
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/14525/1
--
To view, visit http://gerrit.cloudera.org:8080/14525
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I15201bafc5c0e40b230873f92790d4fc2a02bdde
Gerrit-Change-Number: 14525
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] KUDU-2982: Document taking backups on earlier versions of Kudu
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14525
to look at the new patch set (#2).
Change subject: KUDU-2982: Document taking backups on earlier versions of Kudu
......................................................................
KUDU-2982: Document taking backups on earlier versions of Kudu
Adds a section to the backup documentation describing how to
succesfully take backups on Kudu clusters earlier than Kudu 1.10.
Change-Id: I15201bafc5c0e40b230873f92790d4fc2a02bdde
---
M docs/administration.adoc
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/14525/2
--
To view, visit http://gerrit.cloudera.org:8080/14525
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15201bafc5c0e40b230873f92790d4fc2a02bdde
Gerrit-Change-Number: 14525
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2982: Document taking backups on earlier versions of Kudu
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14525 )
Change subject: KUDU-2982: Document taking backups on earlier versions of Kudu
......................................................................
KUDU-2982: Document taking backups on earlier versions of Kudu
Adds a section to the backup documentation describing how to
succesfully take backups on Kudu clusters earlier than Kudu 1.10.
Change-Id: I15201bafc5c0e40b230873f92790d4fc2a02bdde
Reviewed-on: http://gerrit.cloudera.org:8080/14525
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M docs/administration.adoc
1 file changed, 16 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14525
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I15201bafc5c0e40b230873f92790d4fc2a02bdde
Gerrit-Change-Number: 14525
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2982: Document taking backups on earlier versions of Kudu
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14525 )
Change subject: KUDU-2982: Document taking backups on earlier versions of Kudu
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14525/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/14525/1/docs/administration.adoc@449
PS1, Line 449: Additionally, when running the backup you need to pass `--forceFull` to disable
: the incremental backup feature. Now each time the job is run a full backup will be taken.
> Maybe we should add some version/capability detection to the job, so that i
I don't think we need this for a few reasons:
1. The behavior change is so drastically different I think it needs to be an explicitly opt-in to avoid surprise.
2. There is already a very manual process of downloading the newer jar for usage. This is far more inconvenient than adding a flag.
3. There is also a server side configuration change required which is also far more inconvenient than adding a flag.
4. The value of adding this degrades very quickly as more releases come out.
http://gerrit.cloudera.org:8080/#/c/14525/1/docs/administration.adoc@452
PS1, Line 452: far
> "...is far more..."
Done
--
To view, visit http://gerrit.cloudera.org:8080/14525
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15201bafc5c0e40b230873f92790d4fc2a02bdde
Gerrit-Change-Number: 14525
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 22 Oct 2019 16:34:22 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2982: Document taking backups on earlier versions of Kudu
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14525 )
Change subject: KUDU-2982: Document taking backups on earlier versions of Kudu
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14525/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/14525/1/docs/administration.adoc@449
PS1, Line 449: Additionally, when running the backup you need to pass `--forceFull` to disable
: the incremental backup feature. Now each time the job is run a full backup will be taken.
Maybe we should add some version/capability detection to the job, so that it only uses full backups if incremental backups aren't available? If you agree, could you file a JIRA?
http://gerrit.cloudera.org:8080/#/c/14525/1/docs/administration.adoc@452
PS1, Line 452: far
"...is far more..."
--
To view, visit http://gerrit.cloudera.org:8080/14525
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15201bafc5c0e40b230873f92790d4fc2a02bdde
Gerrit-Change-Number: 14525
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 21 Oct 2019 23:52:54 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2982: Document taking backups on earlier versions of Kudu
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14525 )
Change subject: KUDU-2982: Document taking backups on earlier versions of Kudu
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14525
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15201bafc5c0e40b230873f92790d4fc2a02bdde
Gerrit-Change-Number: 14525
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 22 Oct 2019 16:56:06 +0000
Gerrit-HasComments: No