You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by gi...@git.apache.org on 2017/09/28 13:55:27 UTC

[GitHub] jhedberg commented on a change in pull request #583: Mesh fixes and improvements

jhedberg commented on a change in pull request #583: Mesh fixes and improvements
URL: https://github.com/apache/mynewt-core/pull/583#discussion_r141624317
 
 

 ##########
 File path: net/nimble/host/mesh/src/health.c
 ##########
 @@ -99,6 +99,7 @@ static size_t health_get_current(struct bt_mesh_model *mod,
 			fault_count = 0;
 		} else {
 			sys_put_le16(company_id, company_ptr);
+			net_buf_simple_add(msg, fault_count);
 
 Review comment:
   I think I didn't go with a net_buf since net_buf_tailroom() wouldn't actually give you how many faults you can add to the buffer, since there needs to be space for more mesh-internal data after that (in particular the MIC).
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services