You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/26 09:44:40 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #37288: [WIP] Add flag to 'run-tests.py' to support retaining the output.

HyukjinKwon commented on code in PR #37288:
URL: https://github.com/apache/spark/pull/37288#discussion_r929754165


##########
python/run-tests.py:
##########
@@ -71,7 +71,18 @@ def get_valid_filename(s):
     raise RuntimeError("Cannot find assembly build directory, please build Spark first.")
 
 
-def run_individual_python_test(target_dir, test_name, pyspark_python):
+def run_individual_python_test(target_dir, test_name, pyspark_python, keep_test_output):
+    """
+    Runs an individual test. This function is called by the multi-process runner of all tests.
+
+    Parameters
+    ----------
+    target_dir Destination for the Hive and log directory.
+    test_name  Test name.
+    pyspark_python Python version used to run the test.
+    keep_test_output Flag indicating if the test output should be retained after successful execution.

Review Comment:
   ```suggestion
       target_dir
           Destination for the Hive and log directory.
       test_name 
           Test name.
       pyspark_python
           Python version used to run the test.
       keep_test_output
           Flag indicating if the test output should be retained after successful execution.
   ```
   
   Per https://numpydoc.readthedocs.io/en/latest/format.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org