You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/06/19 03:16:38 UTC

[GitHub] [hudi] xushiyan opened a new pull request #1749: [MINOR] Rename test class

xushiyan opened a new pull request #1749:
URL: https://github.com/apache/hudi/pull/1749


   Rename `TestSourceConfig` to `SourceConfigs` as it is not a test class, merely a constants holder
   
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] vinothchandar merged pull request #1749: [MINOR] Rename `TestSourceConfig` to `SourceConfigs`

Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #1749:
URL: https://github.com/apache/hudi/pull/1749


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] xushiyan commented on pull request #1749: [MINOR] Rename `TestSourceConfig` to `SourceConfigs`

Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #1749:
URL: https://github.com/apache/hudi/pull/1749#issuecomment-646821011


   @vinothchandar This may be merged. :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] vinothchandar commented on pull request #1749: [MINOR] Rename `TestSourceConfig` to `SourceConfigs`

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #1749:
URL: https://github.com/apache/hudi/pull/1749#issuecomment-646437364


   Will merge after ci passes


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org