You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/03/13 10:15:38 UTC
[GitHub] [incubator-doris] morningman opened a new pull request #3106:
[Alter] Alter job got stuck because of table is untable
morningman opened a new pull request #3106: [Alter] Alter job got stuck because of table is untable
URL: https://github.com/apache/incubator-doris/pull/3106
This CL solve the issue #3105
I add a new temporary table state `WAITING_STABLE`.
When an alter job is ready to start, it checks whether the table is stable. If it is not stable,
the table state is set to `WAITING_STABLE`. In this state, the tablet repair logic will continue to
repair the tablet until the table becomes stable.
After that, the table state will be reset to SCHEMA_CHANGE/ROLLUP and alter operations will begin.
This is just a temporary state, it does not need to be persistent, and only the master FE can see this state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request
#3106: [Alter] Alter job got stuck because of table is untable
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #3106: [Alter] Alter job got stuck because of table is untable
URL: https://github.com/apache/incubator-doris/pull/3106#discussion_r392208438
##########
File path: fe/src/main/java/org/apache/doris/alter/RollupJobV2.java
##########
@@ -162,7 +162,7 @@ protected void runPendingJob() throws AlterCancelException {
}
}
MarkedCountDownLatch<Long, Long> countDownLatch = new MarkedCountDownLatch<Long, Long>(totalReplicaNum);
- db.readLock();
+ db.writeLock();
Review comment:
OK, I will modify this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on a change in pull request
#3106: [Alter] Alter job got stuck because of table is untable
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on a change in pull request #3106: [Alter] Alter job got stuck because of table is untable
URL: https://github.com/apache/incubator-doris/pull/3106#discussion_r392294815
##########
File path: fe/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java
##########
@@ -185,22 +189,13 @@ protected void runPendingJob() throws AlterCancelException {
}
}
MarkedCountDownLatch<Long, Long> countDownLatch = new MarkedCountDownLatch<>(totalReplicaNum);
- db.readLock();
+ db.writeLock();
Review comment:
Should still use `db.readLock`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on a change in pull request
#3106: [Alter] Alter job got stuck because of table is untable
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on a change in pull request #3106: [Alter] Alter job got stuck because of table is untable
URL: https://github.com/apache/incubator-doris/pull/3106#discussion_r392159921
##########
File path: fe/src/main/java/org/apache/doris/alter/RollupJobV2.java
##########
@@ -162,7 +162,7 @@ protected void runPendingJob() throws AlterCancelException {
}
}
MarkedCountDownLatch<Long, Long> countDownLatch = new MarkedCountDownLatch<Long, Long>(totalReplicaNum);
- db.readLock();
+ db.writeLock();
Review comment:
Could we reduce the write lock scope? because the `tbl.isStable` and `CreateReplicaTask` both need to iterate every replica.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #3106: [Alter]
Alter job got stuck because of table is untable
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #3106: [Alter] Alter job got stuck because of table is untable
URL: https://github.com/apache/incubator-doris/pull/3106
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org