[GitHub] [iceberg] gaborkaszab commented on pull request #6074: API,Core: SnapshotManager to be created through Transaction

[GitBox <gi...@apache.org>]

gaborkaszab commented on PR #6074:
URL: https://github.com/apache/iceberg/pull/6074#issuecomment-1330570824

   @rdblue I saw you have touched this area a few times. Could you please take a look?
   The motivation here was that in Impala we'd like to use SnapshotManager.rollback() in the same transaction with UpdateProperties (the reason is described in https://issues.apache.org/jira/browse/IMPALA-11508) but currently SnapshotManager hides the BaseTransaction it uses.
   I also thought that once SnapshotManager could be created through an external Transaction then the support for the internal one should be dropped but I guess that would break backward compatibility. Should we mark then that behavior deprecated and drop later?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org