You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/03/21 17:33:58 UTC
[GitHub] [arrow] emkornfield opened a new pull request #9763: [Developer Tools] Formalize Minor PRs
emkornfield opened a new pull request #9763:
URL: https://github.com/apache/arrow/pull/9763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #9763: ARROW-12034: [Developer Tools] Formalize Minor PRs
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #9763:
URL: https://github.com/apache/arrow/pull/9763#issuecomment-810562937
+1 from me on the content
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #9763: ARROW-12034: [Developer Tools] Formalize Minor PRs
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #9763:
URL: https://github.com/apache/arrow/pull/9763#issuecomment-810394311
> I do not know how to test the automation / scripts other than "in production" but that might be ok for this kind of PR
@kou gave the pointer of testing on my fork above, which I did.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield closed pull request #9763: ARROW-12034: [Developer Tools] Formalize Minor PRs
Posted by GitBox <gi...@apache.org>.
emkornfield closed pull request #9763:
URL: https://github.com/apache/arrow/pull/9763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #9763: ARROW-12034: [Developer Tools] Formalize Minor PRs
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #9763:
URL: https://github.com/apache/arrow/pull/9763#issuecomment-808931663
Thanks @kou, finally had a time to test this out. It seems to work. One question is if I should add a GHA that provides positive confirmation that the "MINOR:" title is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #9763: ARROW-12034: [Developer Tools] Formalize Minor PRs
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #9763:
URL: https://github.com/apache/arrow/pull/9763#issuecomment-809033212
@kou I tend to agree it might not be need, just might need some getting used of no GHA if MINOR is specified. If people complain, I'll try adding the proposed diff as a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #9763: ARROW-12034: [Developer Tools] Formalize Minor PRs
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #9763:
URL: https://github.com/apache/arrow/pull/9763#issuecomment-803629186
Is there a good way to test this, especially the GHA part?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #9763: ARROW-12034: [Developer Tools] Formalize Minor PRs
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #9763:
URL: https://github.com/apache/arrow/pull/9763#issuecomment-810761494
I'll wait until at least Friday and then merge unless anyone objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #9763: ARROW-12034: [Developer Tools] Formalize Minor PRs
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #9763:
URL: https://github.com/apache/arrow/pull/9763#issuecomment-803658832
The PR title check job is ran on the master branch.
You can test this change by the following:
1. Push the change to https://github.com/emkornfield/arrow/tree/master (not apache/arrow)
2. Create a test PR on https://github.com/emkornfield/arrow (not apache/arrow)
e.g.: https://github.com/kou/arrow/pull/10 is a test PR that was used to test my change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9763: ARROW-12034: [Developer Tools] Formalize Minor PRs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9763:
URL: https://github.com/apache/arrow/pull/9763#issuecomment-803629197
https://issues.apache.org/jira/browse/ARROW-12034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #9763: ARROW-12034: [Developer Tools] Formalize Minor PRs
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #9763:
URL: https://github.com/apache/arrow/pull/9763#issuecomment-808963421
I don't think that we need it but it may be able to implement by the following:
```diff
diff --git a/.github/workflows/dev_pr/link.js b/.github/workflows/dev_pr/link.js
index 550a9cd39..c27b5f8f1 100644
--- a/.github/workflows/dev_pr/link.js
+++ b/.github/workflows/dev_pr/link.js
@@ -19,6 +19,9 @@ function detectJIRAID(title) {
if (!title) {
return null;
}
+ if (title.startsWith("MINOR: ") {
+ return "MINOR";
+ }
const matched = /^(WIP:?\s*)?((ARROW|PARQUET)-\d+)/.exec(title);
if (!matched) {
return null;
@@ -47,15 +50,20 @@ async function haveComment(github, context, pullRequestNumber, body) {
}
async function commentJIRAURL(github, context, pullRequestNumber, jiraID) {
- const jiraURL = `https://issues.apache.org/jira/browse/${jiraID}`;
- if (await haveComment(github, context, pullRequestNumber, jiraURL)) {
+ let body;
+ if (jiraID === "MINOR") {
+ body = 'This is a minor PR.';
+ } else {
+ body = `https://issues.apache.org/jira/browse/${jiraID}`;
+ }
+ if (await haveComment(github, context, pullRequestNumber, body)) {
return;
}
await github.issues.createComment({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: pullRequestNumber,
- body: jiraURL
+ body: body
});
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9763: [Developer Tools] Formalize Minor PRs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9763:
URL: https://github.com/apache/arrow/pull/9763#issuecomment-803629003
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org