You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Thomas Koch <th...@koch.ro> on 2011/09/06 13:19:42 UTC
Review Request: Startup messages should account for common error of missing
leading slash in config files
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1719/
-----------------------------------------------------------
Review request for zookeeper.
Summary
-------
.
This addresses bug ZOOKEEPER-556.
https://issues.apache.org/jira/browse/ZOOKEEPER-556
Diffs
-----
src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 52d3820
src/java/main/org/apache/zookeeper/server/ServerConfig.java ec710cd
src/java/main/org/apache/zookeeper/server/DatadirCleanupManager.java 8c47971
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java be0a410
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java 4ffb24b
src/java/test/org/apache/zookeeper/server/DatadirCleanupManagerTest.java 6b2f45f
Diff: https://reviews.apache.org/r/1719/diff
Testing
-------
Thanks,
Thomas
Re: Review Request: ZOOKEEPER-556 Startup messages should account for common
error of missing leading slash in config files
Posted by Thomas Koch <th...@koch.ro>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1719/
-----------------------------------------------------------
(Updated 2011-09-15 13:09:03.693032)
Review request for zookeeper.
Summary
-------
.
This addresses bug ZOOKEEPER-556.
https://issues.apache.org/jira/browse/ZOOKEEPER-556
Diffs (updated)
-----
src/java/main/org/apache/zookeeper/server/DatadirCleanupManager.java 8c47971
src/java/main/org/apache/zookeeper/server/ServerConfig.java ec710cd
src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 52d3820
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java be0a410
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java 4ffb24b
src/java/main/org/apache/zookeeper/server/util/VerifyingFileFactory.java PRE-CREATION
src/java/test/org/apache/zookeeper/server/DatadirCleanupManagerTest.java 6b2f45f
src/java/test/org/apache/zookeeper/server/util/VerifyingFileFactoryTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/1719/diff
Testing
-------
Thanks,
Thomas
Re: Review Request: ZOOKEEPER-556 Startup messages should account for common
error of missing leading slash in config files
Posted by Patrick Hunt <ph...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1719/
-----------------------------------------------------------
(Updated 2011-09-14 22:17:54.736640)
Review request for zookeeper.
Summary (updated)
-------
.
This addresses bug ZOOKEEPER-556.
https://issues.apache.org/jira/browse/ZOOKEEPER-556
Diffs
-----
src/java/main/org/apache/zookeeper/server/DatadirCleanupManager.java 8c47971
src/java/main/org/apache/zookeeper/server/ServerConfig.java ec710cd
src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 52d3820
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java be0a410
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java 4ffb24b
src/java/main/org/apache/zookeeper/server/util/VerifyingFileFactory.java PRE-CREATION
src/java/test/org/apache/zookeeper/server/DatadirCleanupManagerTest.java 6b2f45f
src/java/test/org/apache/zookeeper/server/util/VerifyingFileFactoryTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/1719/diff
Testing
-------
Thanks,
Thomas
Re: Review Request: Startup messages should account for common error of
missing leading slash in config files
Posted by Thomas Koch <th...@koch.ro>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1719/
-----------------------------------------------------------
(Updated 2011-09-07 11:28:19.044045)
Review request for zookeeper.
Changes
-------
forgot to add two files:
src/java/main/org/apache/zookeeper/server/util/VerifyingFileFactory.java
src/java/test/org/apache/zookeeper/server/util/VerifyingFileFactoryTest.java
Summary
-------
.
This addresses bug ZOOKEEPER-556.
https://issues.apache.org/jira/browse/ZOOKEEPER-556
Diffs (updated)
-----
src/java/main/org/apache/zookeeper/server/DatadirCleanupManager.java 8c47971
src/java/main/org/apache/zookeeper/server/ServerConfig.java ec710cd
src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 52d3820
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java be0a410
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java 4ffb24b
src/java/main/org/apache/zookeeper/server/util/VerifyingFileFactory.java PRE-CREATION
src/java/test/org/apache/zookeeper/server/DatadirCleanupManagerTest.java 6b2f45f
src/java/test/org/apache/zookeeper/server/util/VerifyingFileFactoryTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/1719/diff
Testing
-------
Thanks,
Thomas