You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by er...@apache.org on 2020/03/31 00:38:09 UTC

[lucene-solr] branch master updated: SOLR-12028: BadApple and AwaitsFix annotations usage, Unannotated tests that haven't failed in a while

This is an automated email from the ASF dual-hosted git repository.

erick pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/master by this push:
     new 1ca7067  SOLR-12028: BadApple and AwaitsFix annotations usage, Unannotated tests that haven't failed in a while
1ca7067 is described below

commit 1ca7067a810578d4e246b5434b9cdcec7145d230
Author: Erick Erickson <Er...@gmail.com>
AuthorDate: Mon Mar 30 20:37:55 2020 -0400

    SOLR-12028: BadApple and AwaitsFix annotations usage, Unannotated tests that haven't failed in a while
---
 solr/core/src/test/org/apache/solr/cloud/MultiThreadedOCPTest.java     | 3 ---
 solr/solrj/src/test/org/apache/solr/common/cloud/SolrZkClientTest.java | 1 -
 2 files changed, 4 deletions(-)

diff --git a/solr/core/src/test/org/apache/solr/cloud/MultiThreadedOCPTest.java b/solr/core/src/test/org/apache/solr/cloud/MultiThreadedOCPTest.java
index 0a3efa3..19d6d9f 100644
--- a/solr/core/src/test/org/apache/solr/cloud/MultiThreadedOCPTest.java
+++ b/solr/core/src/test/org/apache/solr/cloud/MultiThreadedOCPTest.java
@@ -60,9 +60,6 @@ public class MultiThreadedOCPTest extends AbstractFullDistribZkTestBase {
   }
 
   @Test
-// commented 20-July-2018   @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
-//commented 20-Sep-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 17-Aug-2018
-  @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // annotated on: 24-Dec-2018
   public void test() throws Exception {
     testParallelCollectionAPICalls();
     testTaskExclusivity();
diff --git a/solr/solrj/src/test/org/apache/solr/common/cloud/SolrZkClientTest.java b/solr/solrj/src/test/org/apache/solr/common/cloud/SolrZkClientTest.java
index 420f9fb..cf9f694 100644
--- a/solr/solrj/src/test/org/apache/solr/common/cloud/SolrZkClientTest.java
+++ b/solr/solrj/src/test/org/apache/solr/common/cloud/SolrZkClientTest.java
@@ -124,7 +124,6 @@ public class SolrZkClientTest extends SolrCloudTestCase {
 
 
   @Test
-  @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // annotated on: 24-Dec-2018
   public void testSimpleUpdateACLs() throws KeeperException, InterruptedException {
     assertTrue("Initial create was in secure mode; please check the test", canRead(defaultClient, PATH));
     assertTrue("Credentialed client should always be able to read", canRead(credentialsClient, PATH));