You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by vanzin <gi...@git.apache.org> on 2018/11/06 21:06:05 UTC

[GitHub] spark pull request #22867: [SPARK-25778] WriteAheadLogBackedBlockRDD in YARN...

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22867#discussion_r231292508
  
    --- Diff: streaming/src/main/scala/org/apache/spark/streaming/rdd/WriteAheadLogBackedBlockRDD.scala ---
    @@ -136,7 +139,7 @@ class WriteAheadLogBackedBlockRDD[T: ClassTag](
             // this dummy directory should not already exist otherwise the WAL will try to recover
             // past events from the directory and throw errors.
             val nonExistentDirectory = new File(
    -          System.getProperty("java.io.tmpdir"), UUID.randomUUID().toString).getAbsolutePath
    +          tmpDir, UUID.randomUUID().toString).getAbsolutePath
    --- End diff --
    
    Basically what I'm suggesting with my latest top-level comment, and what I first suggested here, is to replace `getAbsolutePath` in this line with `.toURI().toString()`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org