You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/28 15:18:53 UTC

[GitHub] [tvm] elvin-n commented on a change in pull request #8153: Fix tvmc for cases when uTMV is not enabled

elvin-n commented on a change in pull request #8153:
URL: https://github.com/apache/tvm/pull/8153#discussion_r641630740



##########
File path: python/tvm/driver/tvmc/model.py
##########
@@ -280,7 +284,10 @@ def export_package(
                 executor_factory, package_path, cross, cross_options, output_format
             )
         elif output_format == "mlf":
-            package_path = export_model_library_format(executor_factory, package_path)
+            if export_model_library_format is not None:
+                package_path = export_model_library_format(executor_factory, package_path)
+            else:
+                raise Exception("micro tvm cannot be loaded, verify USE_MICRO in config.cmake")

Review comment:
       I would like to re-throw an original exception, but would not like to complicate and store one more attribute in global scope. Ok, let's to copy-past message

##########
File path: python/tvm/driver/tvmc/model.py
##########
@@ -280,7 +284,10 @@ def export_package(
                 executor_factory, package_path, cross, cross_options, output_format
             )
         elif output_format == "mlf":
-            package_path = export_model_library_format(executor_factory, package_path)
+            if export_model_library_format is not None:
+                package_path = export_model_library_format(executor_factory, package_path)
+            else:
+                raise Exception("micro tvm cannot be loaded, verify USE_MICRO in config.cmake")

Review comment:
       I would like to re-throw an original exception, but would not like to complicate and store one more attribute in global scope. Ok, let's copy-past message




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org