You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Viraj Jasani (Jira)" <ji...@apache.org> on 2019/11/04 05:57:00 UTC
[jira] [Commented] (HBASE-23245) All MutableHistogram
implementations should remove maxExpected
[ https://issues.apache.org/jira/browse/HBASE-23245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16966419#comment-16966419 ]
Viraj Jasani commented on HBASE-23245:
--------------------------------------
Please review [~enis]
> All MutableHistogram implementations should remove maxExpected
> --------------------------------------------------------------
>
> Key: HBASE-23245
> URL: https://issues.apache.org/jira/browse/HBASE-23245
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Affects Versions: 3.0.0, 2.3.0, 1.6.0
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Fix For: 3.0.0, 2.3.0, 1.6.0
>
>
> MutableHistogram is using HistogramImpl() and not using maxExpected. From all implementation classes, maxExpected should be removed as constructor argument. Also, HistogramImpl() should pass long casting for Integer.MAX_VALUE << 2 else it is treated as -4
--
This message was sent by Atlassian Jira
(v8.3.4#803005)