You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "David Crossley (JIRA)" <ji...@apache.org> on 2005/10/18 02:25:45 UTC
[jira] Commented: (FOR-180) Update forrestbar to be installablein Mozilla Firefox 0.9
[ http://issues.apache.org/jira/browse/FOR-180?page=comments#action_12332314 ]
David Crossley commented on FOR-180:
------------------------------------
Thanks Addi. The new forrestbar.xpi works for me, and the doc patch is fine.
However the forrestbar.diff patch fails. It seems that you moved some files. You need to use 'svn move' for that. Similarly if any files were copied, use 'svn copy'. If you need any help with that then ask on the list. If you have moved and altered some files, then move your copy of the file out of the way, do the 'svn move', then replace it with your saved copy. The other way would be to provide a list of what has been moved and i can do the 'svn move' at this end, then you can patch them.
See the mail list for other discussion.
> Update forrestbar to be installablein Mozilla Firefox 0.9
> ---------------------------------------------------------
>
> Key: FOR-180
> URL: http://issues.apache.org/jira/browse/FOR-180
> Project: Forrest
> Type: Bug
> Components: Forrestbar
> Environment: Mozilla Firefox 0.9
> Reporter: Nicola Ken Barozzi
> Assignee: David Crossley
> Priority: Minor
> Attachments: forrestbar.diff, forrestbar.xml.diff, forrestbar.xpi
>
> Firefox 0.9 will get a new extension install system, with which we must be compatible to be usable there. Being listed in the standard toolbars could be cool too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (FOR-180) Update forrestbar to be installablein
Mozilla Firefox 0.9
Posted by Addi <ad...@rocktreesky.com>.
David Crossley wrote:
>David Crossley wrote:
>
>
>>Addi wrote:
>>
>>
>>> Essentially what needs to happen is:
>>>forrestbar/xpi/content needs to be renamed to forrestbar/xpi/chrome
>>>forrestbar/xpi/content/forrestbar needs to be renamed
>>>forrestbar/xpi/chrome/content
>>>
>>>I tried doing this a number of ways (svn move, svn copy, mkdir - svn
>>>add) and it was just a mess each time. Unfortunately I am slammed at
>>>work and won't be able to muck with this further until maybe Sunday so
>>>if someone can change around the svn dirs,
>>>
>>>
>>I was just about to suggest that i try to get the bits-and-pieces
>>from you patch.
>>
>>
>>
>>>I will patch it on Sunday, as
>>>well as make the changes David brought up in another post on the list.
>>>Sorry that I'm sort of doing a "dump and run" on this.
>>>
>>>
>
>No problem. Sorry that it turned difficult for you.
>It is bad when time is wasted and frustration mounts.
>
>Your notes above helped immensely. The problem
>is the move (rename) of one directory inside another
>moved directory. Needs to be two separate commits,
>which you cannot.
>
>Thanks again.
>
>-David
>
Ah, OK, that makes sense. I wasn't sure how to do that and did it both
ways (first move the top dir, then move the child dir and vice-versa)
but the commit thing would be key there. So, I don't feel so stupid
now. I will practice more with svn when I get chance so that I am more
comfortable with it in the future. Thanks for taking care of it David.
- Addi
Re: [jira] Commented: (FOR-180) Update forrestbar to be installablein Mozilla Firefox 0.9
Posted by David Crossley <cr...@apache.org>.
David Crossley wrote:
> Addi wrote:
> >
> > Essentially what needs to happen is:
> > forrestbar/xpi/content needs to be renamed to forrestbar/xpi/chrome
> > forrestbar/xpi/content/forrestbar needs to be renamed
> > forrestbar/xpi/chrome/content
> >
> > I tried doing this a number of ways (svn move, svn copy, mkdir - svn
> > add) and it was just a mess each time. Unfortunately I am slammed at
> > work and won't be able to muck with this further until maybe Sunday so
> > if someone can change around the svn dirs,
>
> I was just about to suggest that i try to get the bits-and-pieces
> from you patch.
>
> > I will patch it on Sunday, as
> > well as make the changes David brought up in another post on the list.
> > Sorry that I'm sort of doing a "dump and run" on this.
No problem. Sorry that it turned difficult for you.
It is bad when time is wasted and frustration mounts.
Your notes above helped immensely. The problem
is the move (rename) of one directory inside another
moved directory. Needs to be two separate commits,
which you cannot.
Thanks again.
-David
Re: [jira] Commented: (FOR-180) Update forrestbar to be installablein Mozilla Firefox 0.9
Posted by David Crossley <cr...@apache.org>.
Addi wrote:
> >
> Well, I appear to be SVN-challenged. I spent more time than I'd like to
> admit to trying to do this properly but it just isn't giving me a usable
> patch.
When you have some time, we should help you to get past
that little hump. Subversion is wonderful.
> Essentially what needs to happen is:
> forrestbar/xpi/content needs to be renamed to forrestbar/xpi/chrome
> forrestbar/xpi/content/forrestbar needs to be renamed
> forrestbar/xpi/chrome/content
>
> I tried doing this a number of ways (svn move, svn copy, mkdir - svn
> add) and it was just a mess each time. Unfortunately I am slammed at
> work and won't be able to muck with this further until maybe Sunday so
> if someone can change around the svn dirs,
I was just about to suggest that i try to get the bits-and-pieces
from you patch.
-David
> I will patch it on Sunday, as
> well as make the changes David brought up in another post on the list.
> Sorry that I'm sort of doing a "dump and run" on this.
>
> - Addi
Re: [jira] Commented: (FOR-180) Update forrestbar to be installablein
Mozilla Firefox 0.9
Posted by Addi <ad...@rocktreesky.com>.
David Crossley (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/FOR-180?page=comments#action_12332314 ]
>
>David Crossley commented on FOR-180:
>------------------------------------
>
>Thanks Addi. The new forrestbar.xpi works for me, and the doc patch is fine.
>
>However the forrestbar.diff patch fails. It seems that you moved some files. You need to use 'svn move' for that. Similarly if any files were copied, use 'svn copy'. If you need any help with that then ask on the list. If you have moved and altered some files, then move your copy of the file out of the way, do the 'svn move', then replace it with your saved copy. The other way would be to provide a list of what has been moved and i can do the 'svn move' at this end, then you can patch them.
>
Well, I appear to be SVN-challenged. I spent more time than I'd like to
admit to trying to do this properly but it just isn't giving me a usable
patch. Essentially what needs to happen is:
forrestbar/xpi/content needs to be renamed to forrestbar/xpi/chrome
forrestbar/xpi/content/forrestbar needs to be renamed
forrestbar/xpi/chrome/content
I tried doing this a number of ways (svn move, svn copy, mkdir - svn
add) and it was just a mess each time. Unfortunately I am slammed at
work and won't be able to muck with this further until maybe Sunday so
if someone can change around the svn dirs, I will patch it on Sunday, as
well as make the changes David brought up in another post on the list.
Sorry that I'm sort of doing a "dump and run" on this.
- Addi