You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2014/08/01 20:13:26 UTC

[GitHub] couchdb-fauxton pull request: Implement a filter for databases

GitHub user robertkowalski opened a pull request:

    https://github.com/apache/couchdb-fauxton/pull/23

    Implement a filter for databases

    This is a port of https://github.com/apache/couchdb/pull/210 with the difference that I am using the upper tabs now and not the sidebar for the searchinput (like in the Changes-Filter, ca7843b81e9dc85921cb6e612e0e2cc51ce64a98) 
    
    ---
    
    Uses a new model to manage the state of the different search
    filters to filter the view.
    
    Nice feature: the filter for the database (upper input) and
    the filters for the type (buttons) work nicely together,
    so you can filter out all replications for that
    database (let's name it registry)  without the compaction,
    if you choose replication as type and enter "registry" in the
    top input.
    
    Closes COUCHDB-2125

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertkowalski/couchdb-fauxton COUCHDB-2125--database-filter-export

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fauxton/pull/23.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23
    
----
commit 8839b71491ac94d2af99dbaedf2b36db87e8acee
Author: Robert Kowalski <ro...@kowalski.gd>
Date:   2014-08-01T18:10:13Z

    Implement a filter for databases
    
    Uses a new model to manage the state of the different search
    filters to filter the view.
    
    Nice feature: the filter for the database (upper input) and
    the filters for the type (buttons) work nicely together,
    so you can filter out all replications for that
    database (let's name it registry)  without the compaction,
    if you choose replication as type and enter "registry" in the
    top input.
    
    Closes COUCHDB-2125

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Implement a filter for databases

Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/23#issuecomment-52812099
  
    @garrensmith also had a look - merged as 2adfaf932a26a601fea0fc8cf316b6feb9023f99


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Implement a filter for databases

Posted by seanbarclay <gi...@git.apache.org>.
Github user seanbarclay commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/23#issuecomment-52503969
  
    Gotcha @robertkowalski. Nice job. If the width's on Type and PID could be shrunk a touch, that would be the only other thing I would recommend here. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Implement a filter for databases

Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/23#issuecomment-52429789
  
    Hi @seanbarclay, that's a great idea!
    
    I found one case where it was a little bit problematic, the view indexing which also has the viewname in the Object field:
    
    ![bildschirmfoto 2014-08-17 um 19 55 17](https://cloud.githubusercontent.com/assets/298166/3945271/a88a5e1c-2637-11e4-8154-8f5050daf987.png)
    
    I changed the display a little bit and I hope that it fits better now:
    
    ![bildschirmfoto 2014-08-17 um 20 05 00](https://cloud.githubusercontent.com/assets/298166/3945300/667aea8a-2639-11e4-8e28-af7cc6dd7c09.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Implement a filter for databases

Posted by seanbarclay <gi...@git.apache.org>.
Github user seanbarclay commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/23#issuecomment-52358405
  
    Hey @robertkowalski, I looked at the video. In the search input, would it be more intuitive to say "Search by object" instead of  "Search by Databases..."? 
    
    Or... would it be better to rename the "Object" column, "Database Name", and display just the DB name below instead of specifying the URL?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Implement a filter for databases

Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:

    https://github.com/apache/couchdb-fauxton/pull/23


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Implement a filter for databases

Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/23#issuecomment-52809916
  
    Done! Thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Implement a filter for databases

Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/23#issuecomment-51779538
  
    Sorry for my bad explanation of the feature.
    
    If you have alot of Active Tasks, you can use this, to filter them for a given database name. Here is a small video:
    
    https://cloudup.com/iTrXflHiDSZ


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Implement a filter for databases

Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/23#issuecomment-51752525
  
    @robertkowalski I cannot get this to work. If I get a replication going and then try and filter via the databases that being replicated to and from, nothing happens. What should happen. Could you supply some screenshots.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Implement a filter for databases

Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/23#issuecomment-51693010
  
    ping @deathbearbrown @garrensmith


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---