[jira] [Commented] (LUCENE-6597) Geo3d circle creation that covers whole globe throws an IllegalArgumentException

["Karl Wright (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-6597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595890#comment-14595890 ] 

Karl Wright commented on LUCENE-6597:
-------------------------------------

[~dsmiley]: Patch looks like it solves the IllegalArgumentException in the place I was seeing it, and doesn't break anything, so other than adding an explicit test I am good with it.


> Geo3d circle creation that covers whole globe throws an IllegalArgumentException
> --------------------------------------------------------------------------------
>
>                 Key: LUCENE-6597
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6597
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/spatial
>            Reporter: Karl Wright
>         Attachments: LUCENE-6597.patch
>
>
> The following GeoCircle construction:
> {code}
> new GeoCircle(PlanetModel.SPHERE, -20.0 * RADIANS_PER_DEGREE, -20.0 * RADIANS_PER_DEGREE, Math.PI);
> {code}
> ... fails as follows:
> {code}
> Degenerate/parallel vector constructed
> {code}
> The reason is that the plane normal vector cannot be computed in that case.  A special case is warranted for circles that cover the whole globe.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org