You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by ad...@apache.org on 2013/08/12 18:55:57 UTC

svn commit: r1513195 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/DateTimeConverters.java

Author: adrianc
Date: Mon Aug 12 16:55:57 2013
New Revision: 1513195

URL: http://svn.apache.org/r1513195
Log:
Added a FIXME note for a bug introduced in revision 1089946.

Modified:
    ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/DateTimeConverters.java

Modified: ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/DateTimeConverters.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/DateTimeConverters.java?rev=1513195&r1=1513194&r2=1513195&view=diff
==============================================================================
--- ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/DateTimeConverters.java (original)
+++ ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/DateTimeConverters.java Mon Aug 12 16:55:57 2013
@@ -644,6 +644,10 @@ public class DateTimeConverters implemen
             try {
                 return new java.sql.Timestamp(df.parse(str).getTime());
             } catch (ParseException e) {
+                // FIXME: This change needs to be reverted. The Timestamp format is
+                // defined by the JDBC specification. Passing an invalid format is an
+                // application error and the application needs to be fixed.
+                //
                 // before throwing an exception, try a generic format first
                 df = DateFormat.getDateTimeInstance();
                 if (timeZone != null) {