You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "jay-li-csck (via GitHub)" <gi...@apache.org> on 2024/11/26 01:02:33 UTC
[PR] fix: apache/incubator-seata#6678 [incubator-seata-go]
jay-li-csck opened a new pull request, #718:
URL: https://github.com/apache/incubator-seata-go/pull/718
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
Convert table names to uppercase in cache, preventing different tables from being found
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #711
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: apache/incubator-seata#6678 [incubator-seata-go]
Posted by "Code-Fight (via GitHub)" <gi...@apache.org>.
Code-Fight commented on code in PR #718:
URL: https://github.com/apache/incubator-seata-go/pull/718#discussion_r1885049226
##########
pkg/datasource/sql/datasource/base/meta_cache.go:
##########
@@ -92,8 +93,9 @@ func (c *BaseTableMetaCache) refresh(ctx context.Context) {
for i := range v {
tm := v[i]
- if _, ok := c.cache[tm.TableName]; !ok {
- c.cache[tm.TableName] = &entry{
+ var upperTableName = strings.ToUpper(tm.TableName)
Review Comment:
这个ToUpper仅在refresh的加不行,需要在GetTableMeta的时,保证都是一致的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: apache/incubator-seata#6678 [incubator-seata-go]
Posted by "luky116 (via GitHub)" <gi...@apache.org>.
luky116 commented on PR #718:
URL: https://github.com/apache/incubator-seata-go/pull/718#issuecomment-2660898167
@歆帆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: apache/incubator-seata#6678 [incubator-seata-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #718:
URL: https://github.com/apache/incubator-seata-go/pull/718#issuecomment-2525085047
## [](https://sonarcloud.io/dashboard?id=apache_incubator-seata-go&pullRequest=718) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_incubator-seata-go&pullRequest=718&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_incubator-seata-go&pullRequest=718&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-seata-go&pullRequest=718&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-seata-go&pullRequest=718&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-seata-go&pullRequest=718&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_incubator-seata-go&pullRequest=718)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: apache/incubator-seata#6678 [incubator-seata-go]
Posted by "luky116 (via GitHub)" <gi...@apache.org>.
luky116 commented on code in PR #718:
URL: https://github.com/apache/incubator-seata-go/pull/718#discussion_r1874397698
##########
pkg/datasource/sql/datasource/base/meta_cache.go:
##########
@@ -92,8 +93,9 @@ func (c *BaseTableMetaCache) refresh(ctx context.Context) {
for i := range v {
tm := v[i]
Review Comment:
问题不大,补一个单测
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: apache/incubator-seata#6678 [incubator-seata-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #718:
URL: https://github.com/apache/incubator-seata-go/pull/718#issuecomment-2561921110
## [](https://sonarcloud.io/dashboard?id=apache_incubator-seata-go&pullRequest=718) **Quality Gate failed**
Failed conditions
 [26.4% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-seata-go&pullRequest=718&metric=new_duplicated_lines_density&view=list) (required ≤ 3%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_incubator-seata-go&pullRequest=718)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: apache/incubator-seata#6678 [incubator-seata-go]
Posted by "Code-Fight (via GitHub)" <gi...@apache.org>.
Code-Fight commented on PR #718:
URL: https://github.com/apache/incubator-seata-go/pull/718#issuecomment-2993520336
It has been fixed through another PR. Thank you for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: apache/incubator-seata#6678 [incubator-seata-go]
Posted by "Code-Fight (via GitHub)" <gi...@apache.org>.
Code-Fight closed pull request #718: fix: apache/incubator-seata#6678
URL: https://github.com/apache/incubator-seata-go/pull/718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: apache/incubator-seata#6678 [incubator-seata-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #718:
URL: https://github.com/apache/incubator-seata-go/pull/718#issuecomment-2561924077
## [](https://sonarcloud.io/dashboard?id=apache_incubator-seata-go&pullRequest=718) **Quality Gate failed**
Failed conditions
 [26.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-seata-go&pullRequest=718&metric=new_duplicated_lines_density&view=list) (required ≤ 3%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_incubator-seata-go&pullRequest=718)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: apache/incubator-seata#6678 [incubator-seata-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #718:
URL: https://github.com/apache/incubator-seata-go/pull/718#issuecomment-2520510425
## [](https://sonarcloud.io/dashboard?id=apache_incubator-seata-go&pullRequest=718) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_incubator-seata-go&pullRequest=718&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_incubator-seata-go&pullRequest=718&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-seata-go&pullRequest=718&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-seata-go&pullRequest=718&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-seata-go&pullRequest=718&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_incubator-seata-go&pullRequest=718)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org