You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/01/16 20:42:47 UTC

[GitHub] [orc] williamhyun opened a new pull request #628: ORC-735: ConvertTool should not fail at a single ORC file.

williamhyun opened a new pull request #628:
URL: https://github.com/apache/orc/pull/628


   
   ### What changes were proposed in this pull request?
   
   This PR aims to fix a bug in ConvertTool by using the provided schema in case of a single file. 
   
   
   ### Why are the changes needed?
   
   **BEFORE**
   ```
    % java -jar tools/target/orc-tools-1.7.0-SNAPSHOT-uber.jar convert ../examples/TestOrcFile.test1.orc
   Merging schema from ../examples/TestOrcFile.test1.orc
   Exception in thread "main" java.lang.IllegalArgumentException: Unhandled type map<string,struct<int1:int,string1:string>>
           at org.apache.orc.tools.json.JsonSchemaFinder.makeHiveType(JsonSchemaFinder.java:314)
           at org.apache.orc.tools.json.JsonSchemaFinder.makeHiveType(JsonSchemaFinder.java:301)
           at org.apache.orc.tools.json.JsonSchemaFinder.addSchema(JsonSchemaFinder.java:319)
           at org.apache.orc.tools.convert.ConvertTool.buildSchema(ConvertTool.java:81)
           at org.apache.orc.tools.convert.ConvertTool.<init>(ConvertTool.java:188)
           at org.apache.orc.tools.convert.ConvertTool.main(ConvertTool.java:168)
           at org.apache.orc.tools.Driver.main(Driver.java:108)
   ```
   
   **AFTER**
   ```
   % java -jar tools/target/orc-tools-1.7.0-SNAPSHOT-uber.jar convert ../examples/TestOrcFile.test1.orc
   Merging schema from ../examples/TestOrcFile.test1.orc
   Processing ../examples/TestOrcFile.test1.orc
   ```
   
   ### How was this patch tested?
   
   Manually do the above procedure.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun merged pull request #628: ORC-735: ConvertTool should not fail at a single ORC file.

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #628:
URL: https://github.com/apache/orc/pull/628


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #628: ORC-735: ConvertTool should not fail at a single ORC file.

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #628:
URL: https://github.com/apache/orc/pull/628#issuecomment-761678357


   This is merged to master/1.6/1.5.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] williamhyun commented on pull request #628: ORC-735: ConvertTool should not fail at a single ORC file.

Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #628:
URL: https://github.com/apache/orc/pull/628#issuecomment-761683900


   Thank you @dongjoon-hyun !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org