You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/18 18:39:25 UTC

[GitHub] [airflow] hedrickw opened a new issue #13158: UI Doesn't use all of Bootstrap theme css, Airflow 2.0

hedrickw opened a new issue #13158:
URL: https://github.com/apache/airflow/issues/13158


   **Apache Airflow version**: 2.0.0
   
   **Environment**: Ubuntu
   
   - **Cloud provider or hardware configuration**:
   - **OS** (e.g. from /etc/os-release):
   - **Kernel** (e.g. `uname -a`):
   - **Install tools**:
   - **Others**:
   
   **What happened**:
   
   Picked Cyborg.css in web_server config but background is still default
   ![image](https://user-images.githubusercontent.com/23406205/102648950-3f7dd400-411d-11eb-880a-d70e89a5c45c.png)
   
   
   
   <!-- (please include exact error messages if you can) -->
   
   **What you expected to happen**:
   
   <!-- What do you think went wrong? -->
   
   **How to reproduce it**:
   <!---
   
   As minimally and precisely as possible. Keep in mind we do not have access to your cluster or dags.
   
   If you are using kubernetes, please attempt to recreate the issue using minikube or kind.
   
   ## Install minikube/kind
   
   - Minikube https://minikube.sigs.k8s.io/docs/start/
   - Kind https://kind.sigs.k8s.io/docs/user/quick-start/
   
   If this is a UI bug, please provide a screenshot of the bug or a link to a youtube video of the bug in action
   
   You can include images using the .md style of
   ![alt text](http://url/to/img.png)
   
   To record a screencast, mac users can use QuickTime and then create an unlisted youtube video with the resulting .mov file.
   
   --->
   
   
   **Anything else we need to know**:
   
   <!--
   
   How often does this problem occur? Once? Every time etc?
   
   Any relevant logs to include? Put them here in side a detail tag:
   <details><summary>x.log</summary> lots of stuff </details>
   
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ryanahamilton commented on issue #13158: UI Doesn't use all of Bootstrap theme css, Airflow 2.0

Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on issue #13158:
URL: https://github.com/apache/airflow/issues/13158#issuecomment-811918913


   Because we are stuck on an old version of Bootstrap (via secondary dependency through FAB), we had to move away from some of the previous Bootstrap theme patterns. I propose that instead of trying to accommodate this, that we instead remove the feature. It appears to only add maintenance overhead. If differentiation between Airflow deployments is the goal, there is the option to set a different nav bar color by setting a color value in the `navbar_color` config.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] hedrickw commented on issue #13158: UI Doesn't use all of Bootstrap theme css, Airflow 2.0

Posted by GitBox <gi...@apache.org>.
hedrickw commented on issue #13158:
URL: https://github.com/apache/airflow/issues/13158#issuecomment-815869009


   I think that's the correct course of action!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ryanahamilton commented on issue #13158: UI Doesn't use all of Bootstrap theme css, Airflow 2.0

Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on issue #13158:
URL: https://github.com/apache/airflow/issues/13158#issuecomment-815868259


   @hedrickw I've opened #15277 to remove the support of `APP_THEME` going forward. Please offer up any feedback if you don't believe this is the best course of action.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ryanahamilton commented on issue #13158: UI Doesn't use all of Bootstrap theme css, Airflow 2.0

Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on issue #13158:
URL: https://github.com/apache/airflow/issues/13158#issuecomment-807275714


   @hedrickw TIL that APP_THEME was a thing, so it certainly wasn't considered in the 2.0 refresh. I'm curious, is there a specific reason why you want to use an alternative theme?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org