You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by "Michelle Caisse (JIRA)" <ji...@apache.org> on 2008/07/25 19:47:32 UTC
[jira] Commented: (JDO-582) Test case needed for
JDOFatalUserException nested exception argument needs cast to Throwable[]
[ https://issues.apache.org/jira/browse/JDO-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616967#action_12616967 ]
Michelle Caisse commented on JDO-582:
-------------------------------------
I get a compile error:
test:compile:
[javac] Compiling 9 source files to C:\jdo\trunk\api2\target\test-classes
C:\jdo\trunk\api2\test\java\javax\jdo\JDOHelperTest.java:236: inconvertible types
found : java.lang.Throwable
required: java.lang.Throwable[]
if (!(ex.getCause() instanceof Throwable[]))
^
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error
> Test case needed for JDOFatalUserException nested exception argument needs cast to Throwable[]
> ----------------------------------------------------------------------------------------------
>
> Key: JDO-582
> URL: https://issues.apache.org/jira/browse/JDO-582
> Project: JDO
> Issue Type: Bug
> Components: api2, api2-legacy
> Reporter: Erik Bengtson
> Assignee: Richard Schilling
> Fix For: JDO 2 maintenance release 2
>
> Attachments: 20080710-jdo-582.diff, estedExceptionJDOHelper.patch
>
>
> After collecting exceptions from invoking getPersistenceManagerFactory on all implementations, if no implementation has succeeded in returning a PersistenceManagerFactory, an exception is thrown, and the argument should be a Throwable[]. Otherwise, it's treated as a failed object instead of nested exceptions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (JDO-582) Test case needed for JDOFatalUserException
nested exception argument needs cast to Throwable[]
Posted by Richard Schilling <rs...@cognitiongroup.biz>.
O.K. You can back out that patch and apply the latest one I just
uploaded. It compiles on my machine without error now.
But, I also have a new question. If the method
JDOFatalUserException.getNestedExceptions() returns a Throwable[], then
what exactly should the test case be checking for? My understanding was
that I'm supposed to test the nested exceptions array to be sure it's
composed of a Throwable[] array, but the method declaration enforces
that..........
perhaps I need to be told again what we're testing for ....
Richard
Richard Schilling wrote:
> O.K. My bad. I have t ocall the method getNestedExceptions() on the
> exception that is returned. Change forthcomming. .....
>
> Richard
>
>
>
> Michelle Caisse (JIRA) wrote:
>> [
>> https://issues.apache.org/jira/browse/JDO-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616967#action_12616967
>> ]
>> Michelle Caisse commented on JDO-582:
>> -------------------------------------
>>
>> I get a compile error:
>> test:compile:
>> [javac] Compiling 9 source files to
>> C:\jdo\trunk\api2\target\test-classes
>> C:\jdo\trunk\api2\test\java\javax\jdo\JDOHelperTest.java:236:
>> inconvertible types found : java.lang.Throwable
>> required: java.lang.Throwable[]
>> if (!(ex.getCause() instanceof Throwable[]))
>> ^
>> Note: Some input files use unchecked or unsafe operations.
>> Note: Recompile with -Xlint:unchecked for details.
>> 1 error
>>
>>
>>> Test case needed for JDOFatalUserException nested exception argument
>>> needs cast to Throwable[]
>>> ----------------------------------------------------------------------------------------------
>>>
>>>
>>> Key: JDO-582
>>> URL: https://issues.apache.org/jira/browse/JDO-582
>>> Project: JDO
>>> Issue Type: Bug
>>> Components: api2, api2-legacy
>>> Reporter: Erik Bengtson
>>> Assignee: Richard Schilling
>>> Fix For: JDO 2 maintenance release 2
>>>
>>> Attachments: 20080710-jdo-582.diff,
>>> estedExceptionJDOHelper.patch
>>>
>>>
>>> After collecting exceptions from invoking
>>> getPersistenceManagerFactory on all implementations, if no
>>> implementation has succeeded in returning a
>>> PersistenceManagerFactory, an exception is thrown, and the argument
>>> should be a Throwable[]. Otherwise, it's treated as a failed object
>>> instead of nested exceptions.
>>>
>>
>>
>
>
>
Re: [jira] Commented: (JDO-582) Test case needed for JDOFatalUserException
nested exception argument needs cast to Throwable[]
Posted by Richard Schilling <rs...@cognitiongroup.biz>.
O.K. My bad. I have t ocall the method getNestedExceptions() on the
exception that is returned. Change forthcomming. .....
Richard
Michelle Caisse (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/JDO-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616967#action_12616967 ]
>
> Michelle Caisse commented on JDO-582:
> -------------------------------------
>
> I get a compile error:
> test:compile:
> [javac] Compiling 9 source files to C:\jdo\trunk\api2\target\test-classes
> C:\jdo\trunk\api2\test\java\javax\jdo\JDOHelperTest.java:236: inconvertible types
> found : java.lang.Throwable
> required: java.lang.Throwable[]
> if (!(ex.getCause() instanceof Throwable[]))
> ^
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> 1 error
>
>
>> Test case needed for JDOFatalUserException nested exception argument needs cast to Throwable[]
>> ----------------------------------------------------------------------------------------------
>>
>> Key: JDO-582
>> URL: https://issues.apache.org/jira/browse/JDO-582
>> Project: JDO
>> Issue Type: Bug
>> Components: api2, api2-legacy
>> Reporter: Erik Bengtson
>> Assignee: Richard Schilling
>> Fix For: JDO 2 maintenance release 2
>>
>> Attachments: 20080710-jdo-582.diff, estedExceptionJDOHelper.patch
>>
>>
>> After collecting exceptions from invoking getPersistenceManagerFactory on all implementations, if no implementation has succeeded in returning a PersistenceManagerFactory, an exception is thrown, and the argument should be a Throwable[]. Otherwise, it's treated as a failed object instead of nested exceptions.
>>
>
>
Re: [jira] Commented: (JDO-582) Test case needed for JDOFatalUserException
nested exception argument needs cast to Throwable[]
Posted by Richard Schilling <rs...@cognitiongroup.biz>.
Don't recall seeing this in my build. I'll double check.
Richard
Michelle Caisse (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/JDO-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616967#action_12616967 ]
>
> Michelle Caisse commented on JDO-582:
> -------------------------------------
>
> I get a compile error:
> test:compile:
> [javac] Compiling 9 source files to C:\jdo\trunk\api2\target\test-classes
> C:\jdo\trunk\api2\test\java\javax\jdo\JDOHelperTest.java:236: inconvertible types
> found : java.lang.Throwable
> required: java.lang.Throwable[]
> if (!(ex.getCause() instanceof Throwable[]))
> ^
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> 1 error
>
>
>> Test case needed for JDOFatalUserException nested exception argument needs cast to Throwable[]
>> ----------------------------------------------------------------------------------------------
>>
>> Key: JDO-582
>> URL: https://issues.apache.org/jira/browse/JDO-582
>> Project: JDO
>> Issue Type: Bug
>> Components: api2, api2-legacy
>> Reporter: Erik Bengtson
>> Assignee: Richard Schilling
>> Fix For: JDO 2 maintenance release 2
>>
>> Attachments: 20080710-jdo-582.diff, estedExceptionJDOHelper.patch
>>
>>
>> After collecting exceptions from invoking getPersistenceManagerFactory on all implementations, if no implementation has succeeded in returning a PersistenceManagerFactory, an exception is thrown, and the argument should be a Throwable[]. Otherwise, it's treated as a failed object instead of nested exceptions.
>>
>
>