[jira] [Commented] (JDO-658) JDOQL : Support for further methods (String, Enum, Date, JDOHelper)

["Michael Bouschen (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JDO-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129179#comment-13129179 ] 

Michael Bouschen commented on JDO-658:
--------------------------------------

Thanks for implementing the remaining tck test cases.

The patch JDO-658-math_time.patch looks good. Just two comments:
- Any special reason why method testAbs and testSqrt in class SupportedMathMethods are renamed to xtestAbs and xtestSqrt? Then they are not executed and I think this is not an purpose.
- I think the filter specification in method SupportedMathMethods.testTan should call Math.tan instead of Math.sin: "Math.tan(angle) < 0.02 && Math.sin(angle) > -0.02"

I think there is no need to support the remaining Math method like acos, asin, etc. right now, so I created a new JIRA JDO-701 to cover these methods.

I will propose a spec change for the new supported methods covered by this JIRA.
                
> JDOQL : Support for further methods (String, Enum, Date, JDOHelper)
> -------------------------------------------------------------------
>
>                 Key: JDO-658
>                 URL: https://issues.apache.org/jira/browse/JDO-658
>             Project: JDO
>          Issue Type: New Feature
>          Components: specification, tck
>    Affects Versions: JDO 3
>            Reporter: Andy Jefferson
>            Assignee: Craig L Russell
>             Fix For: JDO 3 maintenance release 1
>
>         Attachments: JDO-658-math_time.patch, JDO-658-mbo.patch
>
>
> Consider extending JDOQL in JDO3.1 to include a series of new methods, following the contracts of existing Java classes
> String.charAt(int)
> String.startsWith(String, int)
> String.length()
> String.trim()
> Enum.ordinal()
> Enum.toString()
> The following are obviously deprecated in the JDK, but worth consideration
> Date.getHour()
> Date.getMinutes()
> Date.getSeconds()
> Date.getDay()
> Date.getMonth()
> Date.getYear()
> We already have JDOHelper.getObjectId(Object), so why not add
> JDOHelper.getVersion(Object)
> On a related topic JDO-633 has "List.get(int)".
> Note that all of these are already implemented in the RI.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira