[jira] [Commented] (HIVE-14870) OracleStore: RawStore implementation optimized for Oracle

["Sergey Shelukhin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-14870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849065#comment-15849065 ] 

Sergey Shelukhin commented on HIVE-14870:
-----------------------------------------

Skimmed thru the patch; sorry for the delay.
It looks like most of the SQL in the patch is very generic, with a few easy-to-isolate features like ROWNUM (and quotes to be added for postgres/etc.). The things like PartitionFilterGenerator, that use DB-specific approach, already fairly well isolated.
Some TODOs may need follow-up (e.g. implement filters where it looks like something is already implemented).

The SDS table changes should be doable separately from this change, by changing datanucleus schema and making a corresponding upgrade script, it sounds like a good idea.

It doesn't address the questions above wrt upgrade scripts, conversion scripts, etc. 
Scripts aside, Hybrid...Proxy doesn't look like it's a viable upgrade/conversion path for an average user.

I think it should be possible to do it in 3.5 steps.
1) Make low-hanging-fruit schema changes in a regular manner, if desired.
2) Introduce SqlObjectStore, which is basically already there in this patch. Code similar to one in ACID sql query helper and directSQL code might help make the less-trivial of the queries compatible across DBs.
3) Deprecate/drop ObjectStore.
3.5) Make schema changes that datanucleus makes impossible, if any (or all of them if (1) is not done).

> OracleStore: RawStore implementation optimized for Oracle
> ---------------------------------------------------------
>
>                 Key: HIVE-14870
>                 URL: https://issues.apache.org/jira/browse/HIVE-14870
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Chris Drome
>            Assignee: Chris Drome
>         Attachments: HIVE-14870.patch, OracleStoreDesignProposal.pdf, schema-oraclestore.sql
>
>
> The attached document is a proposal for a RawStore implementation which is optimized for Oracle and replaces DataNucleus. The document outlines schema changes, OracleStore implementation details, and performance tests against ObjectStore, ObjectStore+DirectSQL, and OracleStore.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)