You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by Albumen Kevin <al...@apache.org> on 2021/03/11 14:54:43 UTC

Re: Re: Remove FastJSON dependency

Hi all,

According to the mailing thread above, fastjson will be removed in the
later except `dubbo-serialization-fastjson` module.

Albumen


On Sat, Feb 27, 2021 at 12:21 AM KimmKing <ki...@apache.org> wrote:

> +1, keep gson and remove fastjson.
>
>
>
>
>
> At 2021-02-20 14:15:30, "Yeauty YE" <ye...@gmail.com> wrote:
> >
> >First of all, dubbo is positioned as a lightweight framework, so in
> theory, only one framework needs to be kept for json. Secondly, the scene
> of json operation is not the most frequent main scene, so it will not
> affect dubbo’s performance. Finally, since it is a framework for
> internationalization, security is very important among them. In summary,
> keep Gson and abandon FastJson.
> >
> >In order to prevent dependency problems caused by user upgrades, I
> suggest:
> >* delete FastJSON from `dubbo-all pom.xml` and `dubbo-common pom.xml`
> (Ensure the purity of the Dubbo core)
> >* Fastjson serialization module should be preserved
> >
> >
> >On 2021/02/18 06:43:27, Jun Liu <l....@apache.org> wrote:
> >> Hi,>
> >>
> >> > For so long, Dubbo has both Gson and FastJSON, and many modules rely
> on>
> >> > these two json serialization tools.>
> >>
> >>
> >> I think there’s no need to use two libraries as they provide almost the
> same ability. Personally, I have no inclination about which one to keep. >
> >>
> >> >  I am worried that removing one will>
> >> > cause compatibility and stability issues.>
> >>
> >> Here’re the possible impacts that I can think of at this moment:>
> >> * Fastjson serialization module should be preserved>
> >> * Internal dependency of Dubbo on json can be unified into a library,
> and most scenarios should have no compatibility problems>
> >> * dubbo-all  pom.xml introduces the transmission dependency of both
> Gson and Fastjson. Removing one of them may bring dependency problems to
> users who want to upgrade. Considering that fastjson has just been added in
> 2.7.8, I think we can choose to remove Fastjson for long time maintenance
> good, Or, we can choose to keep both in pom.xml for the time being.>
> >>
> >> Jun>
> >>
> >> > On Feb 18, 2021, at 12:09 PM, Albumen Kevin <al...@apache.org>
> wrote:>
> >> > >
> >> > Hi community,>
> >> > >
> >> > There is a pull request removing FastJSON dependency for
> apache/dubbo:>
> >> > >
> >> > https://github.com/apache/dubbo/pull/7187>
> >> > >
> >> > For so long, Dubbo has both Gson and FastJSON, and many modules rely
> on>
> >> > these two json serialization tools. I am worried that removing one
> will>
> >> > cause compatibility and stability issues.>
> >> > >
> >> > Albumen>
> >>
> >>
>