You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "r7raul1984 (GitHub)" <gi...@apache.org> on 2018/08/27 10:05:33 UTC
[GitHub] [kylin] r7raul1984 opened pull request #212: KYLIN-3514
Support AUC UDAF
[ Full content available at: https://github.com/apache/kylin/pull/212 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [kylin] coveralls commented on issue #212: KYLIN-3514
Support AUC UDAF
Posted by "coveralls (GitHub)" <gi...@apache.org>.
## Pull Request Test Coverage Report for [Build 3477](https://coveralls.io/builds/18683049)
* **78** of **109** **(71.56%)** changed or added relevant lines in **7** files are covered.
* **3** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.1%**) to **23.023%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-metadata/src/main/java/org/apache/kylin/measure/auc/AucMesureType.java](https://coveralls.io/builds/18683049/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fauc%2FAucMesureType.java#L68) | 11 | 13 | 84.62%
| [core-metadata/src/main/java/org/apache/kylin/measure/auc/AucCounter.java](https://coveralls.io/builds/18683049/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fauc%2FAucCounter.java#L49) | 32 | 36 | 88.89%
| [core-metadata/src/main/java/org/apache/kylin/measure/auc/AucSerializer.java](https://coveralls.io/builds/18683049/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fauc%2FAucSerializer.java#L68) | 23 | 28 | 82.14%
| [core-metadata/src/main/java/org/apache/kylin/measure/auc/AucAggregator.java](https://coveralls.io/builds/18683049/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fauc%2FAucAggregator.java#L31) | 8 | 17 | 47.06%
| [core-metadata/src/main/java/org/apache/kylin/measure/auc/AucAggFunc.java](https://coveralls.io/builds/18683049/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fauc%2FAucAggFunc.java#L23) | 0 | 11 | 0.0%
<!-- | **Total:** | **78** | **109** | **71.56%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/18683049/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/18683049) |
| :-- | --: |
| Change from base [Build 3473](https://coveralls.io/builds/18680057): | 0.1% |
| Covered Lines: | 15915 |
| Relevant Lines: | 69127 |
---
##### 💛 - [Coveralls](https://coveralls.io)
[ Full content available at: https://github.com/apache/kylin/pull/212 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [kylin] shaofengshi commented on issue #212: KYLIN-3514
Support AUC UDAF
Posted by "shaofengshi (GitHub)" <gi...@apache.org>.
How to use this function in Kylin? I didn't see the UDF implementation. Please provide some description and sample for us to understand this function. Thanks!
[ Full content available at: https://github.com/apache/kylin/pull/212 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [kylin] r7raul1984 commented on pull request #212:
KYLIN-3514 Support AUC UDAF
Posted by "r7raul1984 (GitHub)" <gi...@apache.org>.
ok
[ Full content available at: https://github.com/apache/kylin/pull/212 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [kylin] shaofengshi commented on issue #212: KYLIN-3514
Support AUC UDAF
Posted by "shaofengshi (GitHub)" <gi...@apache.org>.
How to use this function in Kylin? I didn't see the UDF implementation. Please provide some description and sample for us to understand this function. Thanks!
[ Full content available at: https://github.com/apache/kylin/pull/212 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [kylin] asfgit commented on issue #212: KYLIN-3514 Support
AUC UDAF
Posted by "asfgit (GitHub)" <gi...@apache.org>.
Can one of the admins verify this patch?
[ Full content available at: https://github.com/apache/kylin/pull/212 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [kylin] r7raul1984 commented on pull request #212:
KYLIN-3514 Support AUC UDAF
Posted by "r7raul1984 (GitHub)" <gi...@apache.org>.
I use stream api in my code. And I found UT on master branch with JDK 1.7(deprecated): Kylin-Master-JDK-1.7 in kylin docs.So I add this config.
[ Full content available at: https://github.com/apache/kylin/pull/212 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [kylin] yiming187 commented on pull request #212: KYLIN-3514
Support AUC UDAF
Posted by "yiming187 (GitHub)" <gi...@apache.org>.
Do you mean this commit only works in JDK8+?
[ Full content available at: https://github.com/apache/kylin/pull/212 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [kylin] codecov-io commented on issue #212: KYLIN-3514
Support AUC UDAF
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/kylin/pull/212?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@32c6593`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `66.97%`.
[](https://codecov.io/gh/apache/kylin/pull/212?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #212 +/- ##
=========================================
Coverage ? 21.02%
Complexity ? 4355
=========================================
Files ? 1084
Lines ? 69127
Branches ? 10011
=========================================
Hits ? 14532
Misses ? 53214
Partials ? 1381
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/212?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/kylin/measure/auc/AucAggFunc.java](https://codecov.io/gh/apache/kylin/pull/212/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9hdWMvQXVjQWdnRnVuYy5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...a/org/apache/kylin/measure/MeasureTypeFactory.java](https://codecov.io/gh/apache/kylin/pull/212/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9NZWFzdXJlVHlwZUZhY3RvcnkuamF2YQ==) | `57.57% <100%> (ø)` | `14 <0> (?)` | |
| [...src/main/java/org/apache/kylin/util/KryoUtils.java](https://codecov.io/gh/apache/kylin/pull/212/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdXRpbC9LcnlvVXRpbHMuamF2YQ==) | `85% <100%> (ø)` | `5 <0> (?)` | |
| [...va/org/apache/kylin/measure/auc/AucAggregator.java](https://codecov.io/gh/apache/kylin/pull/212/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9hdWMvQXVjQWdncmVnYXRvci5qYXZh) | `47.05% <47.05%> (ø)` | `4 <4> (?)` | |
| [.../java/org/apache/kylin/measure/auc/AucCounter.java](https://codecov.io/gh/apache/kylin/pull/212/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9hdWMvQXVjQ291bnRlci5qYXZh) | `75% <75%> (ø)` | `11 <11> (?)` | |
| [...va/org/apache/kylin/measure/auc/AucSerializer.java](https://codecov.io/gh/apache/kylin/pull/212/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9hdWMvQXVjU2VyaWFsaXplci5qYXZh) | `82.14% <82.14%> (ø)` | `4 <4> (?)` | |
| [...va/org/apache/kylin/measure/auc/AucMesureType.java](https://codecov.io/gh/apache/kylin/pull/212/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9hdWMvQXVjTWVzdXJlVHlwZS5qYXZh) | `84.61% <84.61%> (ø)` | `4 <4> (?)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/212?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/212?src=pr&el=footer). Last update [32c6593...307d2b2](https://codecov.io/gh/apache/kylin/pull/212?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/kylin/pull/212 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [kylin] shaofengshi commented on issue #212: KYLIN-3514
Support AUC UDAF
Posted by "shaofengshi (GitHub)" <gi...@apache.org>.
This is not a complete implementation, for example, it doesn't translate the query to this measure type. Will close it now, and revisit it later if find a total solution. Thank you!
[ Full content available at: https://github.com/apache/kylin/pull/212 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [kylin] shaofengshi closed pull request #212: KYLIN-3514
Support AUC UDAF
Posted by "shaofengshi (GitHub)" <gi...@apache.org>.
[ pull request closed by shaofengshi ]
[ Full content available at: https://github.com/apache/kylin/pull/212 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [kylin] shaofengshi commented on pull request #212:
KYLIN-3514 Support AUC UDAF
Posted by "shaofengshi (GitHub)" <gi...@apache.org>.
Could you please add the copyright of smile-core to Kylin's LICENSE file in the root folder?
[ Full content available at: https://github.com/apache/kylin/pull/212 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [kylin] r7raul1984 commented on pull request #212:
KYLIN-3514 Support AUC UDAF
Posted by "r7raul1984 (GitHub)" <gi...@apache.org>.
I use stream api in my code. And I find UT on master branch with JDK 1.7(deprecated): Kylin-Master-JDK-1.7 in kylin docs.So I add this config.
[ Full content available at: https://github.com/apache/kylin/pull/212 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org