You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by PurelyApplied <gi...@git.apache.org> on 2017/08/23 17:55:47 UTC

[GitHub] geode pull request #734: GEODE-3508: Remove unused internal deprecated class...

GitHub user PurelyApplied opened a pull request:

    https://github.com/apache/geode/pull/734

    GEODE-3508: Remove unused internal deprecated classes.

    * Update ClusterConfigurationNotAvailableException to extend Exception directly, rather than the deprecated class.
    
    ------
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    - [x] Does `gradlew build` run cleanly?
    
    - [n/a] Have you written or updated unit tests to verify your changes?
    
    - [n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PurelyApplied/geode geode-3508

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/734.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #734
    
----
commit 86e6daf53fa1660ea4744415a3d9f613f4b5a3f5
Author: Patrick Rhomberg <pr...@pivotal.io>
Date:   2017-08-23T17:49:32Z

    GEODE-3508: Remove three unused internal deprecated classes.
    
    * Update ClusterConfigurationNotAvailableException to extend Exception directly, rather than the deprecated class.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #734: GEODE-3508: Remove unused internal deprecated classes.

Posted by PurelyApplied <gi...@git.apache.org>.

Github user PurelyApplied commented on the issue:

    https://github.com/apache/geode/pull/734
  
    Precheckin green.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #734: GEODE-3508: Remove unused internal deprecated class...

Posted by kirklund <gi...@git.apache.org>.

Github user kirklund commented on a diff in the pull request:

https://github.com/apache/geode/pull/734#discussion_r134875140

--- Diff: geode-core/src/main/java/org/apache/geode/internal/process/ClusterConfigurationNotAvailableException.java ---
@@ -1,33 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
- * agreements. See the NOTICE file distributed with this work for additional information regarding
- * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance with the License. You may obtain a
- * copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software distributed under the License
- * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
- * or implied. See the License for the specific language governing permissions and limitations under
- * the License.
- */
-package org.apache.geode.internal.process;
-
-/**
- * Exception thrown during server startup when it requests the locators for shared configuration and
- * does not receive it.
- *
- * @since GemFire 8.0
- * @deprecated Please use
--- End diff --

It's probably ok to delete this, but I literally just deprecated this class a week or so ago. The only reason I kept it around was in case it's ever on the wire during a rolling upgrade -- I think it's very unlikely but I couldn't rule it out.

The @since is GemFire 8.0 (that's the version it was introduced in). I should have added @deprecated since Geode 1.3.0 which hasn't released yet.

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #734: GEODE-3508: Remove unused internal deprecated class...

Posted by PurelyApplied <gi...@git.apache.org>.

Github user PurelyApplied commented on a diff in the pull request:

https://github.com/apache/geode/pull/734#discussion_r134881817

Looks like `@deprecated` wants to be one, too. Better use those backticks.

I definitely misread those annotations, yes. I should get in the habit of checking the `git blame` to be sure about the deprecation date.

Other than the reason you mentioned -- possibly using it during a rolling upgrade -- is there a good reason to deprecate an internal class instead of simply removing it? It was my understanding that internal packages didn't hold any promise of API stability. Or could there be a backwards-compatibility issue that I'm not seeing?

[GitHub] geode issue #734: GEODE-3508: Remove unused internal deprecated classes.

Posted by kirklund <gi...@git.apache.org>.

Github user kirklund commented on the issue:

    https://github.com/apache/geode/pull/734
  
    I'll pull this in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #734: GEODE-3508: Remove unused internal deprecated class...

Posted by kirklund <gi...@git.apache.org>.

Github user kirklund commented on a diff in the pull request:

https://github.com/apache/geode/pull/734#discussion_r135605423

Just delete it. It's fine.

[GitHub] geode issue #734: GEODE-3508: Remove unused internal deprecated classes.

Posted by kirklund <gi...@git.apache.org>.

Github user kirklund commented on the issue:

    https://github.com/apache/geode/pull/734
  
    I forgot to add "This closes #734" -- please close as it's now in develop.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #734: GEODE-3508: Remove unused internal deprecated class...

Posted by kirklund <gi...@git.apache.org>.

Github user kirklund commented on a diff in the pull request:

    https://github.com/apache/geode/pull/734#discussion_r134875716
  
    --- Diff: geode-core/src/main/java/org/apache/geode/internal/process/ClusterConfigurationNotAvailableException.java ---
    @@ -1,33 +0,0 @@
    -/*
    - * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
    - * agreements. See the NOTICE file distributed with this work for additional information regarding
    - * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
    - * "License"); you may not use this file except in compliance with the License. You may obtain a
    - * copy of the License at
    - *
    - * http://www.apache.org/licenses/LICENSE-2.0
    - *
    - * Unless required by applicable law or agreed to in writing, software distributed under the License
    - * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
    - * or implied. See the License for the specific language governing permissions and limitations under
    - * the License.
    - */
    -package org.apache.geode.internal.process;
    -
    -/**
    - * Exception thrown during server startup when it requests the locators for shared configuration and
    - * does not receive it.
    - *
    - * @since GemFire 8.0
    - * @deprecated Please use
    --- End diff --
    
    Oops, someone has a github name of "since" in mixed case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #734: GEODE-3508: Remove unused internal deprecated class...

Posted by PurelyApplied <gi...@git.apache.org>.

Github user PurelyApplied closed the pull request at:

    https://github.com/apache/geode/pull/734


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---