You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/03/31 01:23:53 UTC
[GitHub] [spark] LuciferYang opened a new pull request, #40613: Revert "[SPARK-39204][CORE] Change `Utils.createTempDir` and `Utils.createDirectory` call the same logic method in `JavaUtils`
LuciferYang opened a new pull request, #40613:
URL: https://github.com/apache/spark/pull/40613
This reverts commit 5cb5d1fa66ad9d6e94beb17d3fda3a8f220bc371.
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40613: [SPARK-42974][CORE] Restore `Utils.createTempDir` to use the `ShutdownHookManager` and clean up `JavaUtils.createTempDir` method.
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40613:
URL: https://github.com/apache/spark/pull/40613#discussion_r1153957701
##########
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/TestShuffleDataContext.java:
##########
@@ -47,8 +47,9 @@ public TestShuffleDataContext(int numLocalDirs, int subDirsPerLocalDir) {
}
public void create() throws IOException {
+ String root = System.getProperty("java.io.tmpdir");
for (int i = 0; i < localDirs.length; i ++) {
- localDirs[i] = JavaUtils.createTempDir().getAbsolutePath();
+ localDirs[i] = JavaUtils.createDirectory(root, "spark").getAbsolutePath();
Review Comment:
Will clean up by
https://github.com/apache/spark/blob/35503a535771d257b517e7ddf2adfaefefd97dad/common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/TestShuffleDataContext.java#L59-L67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #40613: [SPARK-42974][CORE] Restore `Utils.createTempDir` to use the `ShutdownHookManager` and clean up `JavaUtils.createTempDir` method.
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #40613:
URL: https://github.com/apache/spark/pull/40613#issuecomment-1494353798
I think there are two reasons:
1. branch-3.3 and the master both use `spark.util.ShutdownHookManager`, but 3.4 not, I think they should keep the same.
2. @sadikovi mentioned earlier `DeleteOnExit functionality can cause performance issues due memory leaks under heavy load in certain JDK versions because while the temporary files are deleted, the entries in the map are never cleared.
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #40613: [SPARK-42974][CORE] Restore `Utils.createTempDir` to use the `ShutdownHookManager` and clean up `JavaUtils.createTempDir` method.
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #40613:
URL: https://github.com/apache/spark/pull/40613#issuecomment-1492862165
friendly ping @srowen @sadikovi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40613: [SPARK-42974][CORE] Restore `Utils.createTempDir` to use the `ShutdownHookManager` and clean up `JavaUtils.createTempDir` method.
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40613:
URL: https://github.com/apache/spark/pull/40613#discussion_r1153956628
##########
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalBlockHandlerSuite.java:
##########
@@ -125,7 +125,7 @@ private void checkDiagnosisResult(
int reduceId = 0;
// prepare the checksum file
- File tmpDir = JavaUtils.createTempDir();
+ File tmpDir = JavaUtils.createDirectory(System.getProperty("java.io.tmpdir"), "spark");
Review Comment:
tmpDir will cleanup at
https://github.com/apache/spark/blob/35503a535771d257b517e7ddf2adfaefefd97dad/common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalBlockHandlerSuite.java#L190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40613: [SPARK-42974][CORE] Restore `Utils.createTempDir` to use the `ShutdownHookManager` and clean up `JavaUtils.createTempDir` method.
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40613:
URL: https://github.com/apache/spark/pull/40613#discussion_r1153958746
##########
streaming/src/test/java/test/org/apache/spark/streaming/JavaAPISuite.java:
##########
@@ -1476,7 +1476,7 @@ public void testCheckpointMasterRecovery() throws InterruptedException, IOExcept
Arrays.asList(1,4),
Arrays.asList(8,7));
- File tempDir = JavaUtils.createTempDir();
+ File tempDir = Utils.createTempDir(System.getProperty("java.io.tmpdir"), "spark");
Review Comment:
in streaming module, can change to call Utils.createTempDir
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a diff in pull request #40613: [SPARK-42974][CORE] Restore `Utils.createTempDir` to use the `ShutdownHookManager` and clean up `JavaUtils.createTempDir` method.
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on code in PR #40613:
URL: https://github.com/apache/spark/pull/40613#discussion_r1155113334
##########
core/src/test/java/test/org/apache/spark/Java8RDDAPISuite.java:
##########
@@ -246,7 +246,7 @@ public void mapPartitions() {
@Test
public void sequenceFile() throws IOException {
- File tempDir = JavaUtils.createTempDir();
+ File tempDir = Utils.createTempDir(System.getProperty("java.io.tmpdir"), "spark");
Review Comment:
I think this is OK; we can also add an overload of createTempDir so that Java can call this without repeating the arguments, but it's not a big deal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #40613: [SPARK-42974][CORE] Restore `Utils.createTempDir` to use the `ShutdownHookManager` and clean up `JavaUtils.createTempDir` method.
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #40613:
URL: https://github.com/apache/spark/pull/40613#issuecomment-1494344667
I don't see a strong reason to. We don't have a specific issue this solves right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40613: [SPARK-42974][CORE] Restore `Utils.createTempDir` to use the `ShutdownHookManager` and clean up `JavaUtils.createTempDir` method.
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40613:
URL: https://github.com/apache/spark/pull/40613#discussion_r1155193276
##########
core/src/test/java/test/org/apache/spark/Java8RDDAPISuite.java:
##########
@@ -246,7 +246,7 @@ public void mapPartitions() {
@Test
public void sequenceFile() throws IOException {
- File tempDir = JavaUtils.createTempDir();
+ File tempDir = Utils.createTempDir(System.getProperty("java.io.tmpdir"), "spark");
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #40613: [SPARK-42974][CORE] Restore `Utils.createTempDir` to use the `ShutdownHookManager` and clean up `JavaUtils.createTempDir` method.
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #40613:
URL: https://github.com/apache/spark/pull/40613#issuecomment-1494341174
@srowen Does this not need to be merged into branch-3.4?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40613: Revert "[SPARK-39204][CORE] Change `Utils.createTempDir` and `Utils.createDirectory` call the same logic method in `JavaUtils`
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40613:
URL: https://github.com/apache/spark/pull/40613#discussion_r1153928232
##########
core/src/main/scala/org/apache/spark/util/Utils.scala:
##########
@@ -330,7 +351,9 @@ private[spark] object Utils extends Logging {
def createTempDir(
root: String = System.getProperty("java.io.tmpdir"),
namePrefix: String = "spark"): File = {
- JavaUtils.createTempDir(root, namePrefix)
+ val dir = createDirectory(root, namePrefix)
Review Comment:
https://github.com/apache/spark/pull/36529#discussion_r1153918687
@srowen @sadikovi
After this revert, they are two different implementations I think this can solve the problem. For `JavaUtils.createTempDir`, I will find other ways to solve it, it is only call by test code now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40613: [SPARK-42974][CORE] Restore `Utils.createTempDir` to use the `ShutdownHookManager` and clean up `JavaUtils.createTempDir` method.
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40613:
URL: https://github.com/apache/spark/pull/40613#discussion_r1153957872
##########
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java:
##########
@@ -243,7 +243,9 @@ protected void serviceInit(Configuration externalConf) throws Exception {
boolean stopOnFailure = _conf.getBoolean(STOP_ON_FAILURE_KEY, DEFAULT_STOP_ON_FAILURE);
if (_recoveryPath == null && _conf.getBoolean(INTEGRATION_TESTING, false)) {
- _recoveryPath = new Path(JavaUtils.createTempDir().toURI());
+ File tempDir = JavaUtils.createDirectory(System.getProperty("java.io.tmpdir"), "spark");
Review Comment:
A test only code path, so I think `deleteOnExit` is ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40613: [SPARK-42974][CORE] Restore `Utils.createTempDir` to use the `ShutdownHookManager` and clean up `JavaUtils.createTempDir` method.
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40613:
URL: https://github.com/apache/spark/pull/40613#discussion_r1153958604
##########
core/src/test/java/test/org/apache/spark/JavaAPISuite.java:
##########
@@ -93,7 +94,7 @@ public class JavaAPISuite implements Serializable {
@Before
public void setUp() throws IOException {
sc = new JavaSparkContext("local", "JavaAPISuite");
- tempDir = JavaUtils.createTempDir();
+ tempDir = Utils.createTempDir(System.getProperty("java.io.tmpdir"), "spark");
Review Comment:
in core module, change to call Utils.createTempDir
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #40613: [SPARK-42974][CORE] Restore `Utils.createTempDir` to use the `ShutdownHookManager` and clean up `JavaUtils.createTempDir` method.
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen closed pull request #40613: [SPARK-42974][CORE] Restore `Utils.createTempDir` to use the `ShutdownHookManager` and clean up `JavaUtils.createTempDir` method.
URL: https://github.com/apache/spark/pull/40613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #40613: [SPARK-42974][CORE] Restore `Utils.createTempDir` to use the `ShutdownHookManager` and clean up `JavaUtils.createTempDir` method.
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #40613:
URL: https://github.com/apache/spark/pull/40613#issuecomment-1494327133
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #40613: [SPARK-42974][CORE] Restore `Utils.createTempDir` to use the `ShutdownHookManager` and clean up `JavaUtils.createTempDir` method.
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #40613:
URL: https://github.com/apache/spark/pull/40613#issuecomment-1494361090
Right, but we haven't observed this actual problem as far as I know.
I'm not against back-porting, go for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #40613: [SPARK-42974][CORE] Restore `Utils.createTempDir` to use the `ShutdownHookManager` and clean up `JavaUtils.createTempDir` method.
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #40613:
URL: https://github.com/apache/spark/pull/40613#issuecomment-1493559038
Can we push forward this one ? @srowen @sadikovi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40613: Revert "[SPARK-39204][CORE] Change `Utils.createTempDir` and `Utils.createDirectory` call the same logic method in `JavaUtils`
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40613:
URL: https://github.com/apache/spark/pull/40613#discussion_r1153930483
##########
core/src/main/scala/org/apache/spark/util/Utils.scala:
##########
@@ -320,7 +320,28 @@ private[spark] object Utils extends Logging {
* newly created, and is not marked for automatic deletion.
*/
def createDirectory(root: String, namePrefix: String = "spark"): File = {
- JavaUtils.createDirectory(root, namePrefix)
+ var attempts = 0
Review Comment:
If we believe that `createDirectory` has no problem, we can only revert `createTempDir` part
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40613: [SPARK-42974][CORE] Separate Implementation of `Utils.createTempDir` and `JavaUtils.createTempDir`
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40613:
URL: https://github.com/apache/spark/pull/40613#discussion_r1153934642
##########
core/src/main/scala/org/apache/spark/util/Utils.scala:
##########
@@ -320,7 +320,28 @@ private[spark] object Utils extends Logging {
* newly created, and is not marked for automatic deletion.
*/
def createDirectory(root: String, namePrefix: String = "spark"): File = {
- JavaUtils.createDirectory(root, namePrefix)
+ var attempts = 0
Review Comment:
I think this part don't needs to be changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40613: [SPARK-42974][CORE] Restore `Utils.createTempDir` to use the `ShutdownHookManager` and clean up `JavaUtils.createTempDir` method.
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40613:
URL: https://github.com/apache/spark/pull/40613#discussion_r1153955764
##########
common/network-common/src/test/java/org/apache/spark/network/StreamTestHelper.java:
##########
@@ -49,7 +49,7 @@ private static ByteBuffer createBuffer(int bufSize) {
}
StreamTestHelper() throws Exception {
- tempDir = JavaUtils.createTempDir();
+ tempDir = JavaUtils.createDirectory(System.getProperty("java.io.tmpdir"), "spark");
Review Comment:
`tempDir` will cleanup by
https://github.com/apache/spark/blob/35503a535771d257b517e7ddf2adfaefefd97dad/common/network-common/src/test/java/org/apache/spark/network/StreamTestHelper.java#L90-L98
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40613: [SPARK-42974][CORE] Restore `Utils.createTempDir` to use the `ShutdownHookManager` and clean up `JavaUtils.createTempDir` method.
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40613:
URL: https://github.com/apache/spark/pull/40613#discussion_r1153958391
##########
core/src/test/java/test/org/apache/spark/Java8RDDAPISuite.java:
##########
@@ -246,7 +246,7 @@ public void mapPartitions() {
@Test
public void sequenceFile() throws IOException {
- File tempDir = JavaUtils.createTempDir();
+ File tempDir = Utils.createTempDir(System.getProperty("java.io.tmpdir"), "spark");
Review Comment:
in core module, change to call `Utils.createTempDir`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org